Repository navigation
Conversation
…ndaries The expectation branched on which block was being read and indexed TEST_DATA with the running row number. When the server returns the eight rows in one block, that reads past TEST_DATA (UBSan: index 4 out of bounds, client_ut.cpp:625-627); the values matched only because TEST_DATA2 happened to follow it in memory.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while running the client suite under UBSan for #575.
InsertDatainserts two blocks of four rows, then checks the selected rows with a branch on which block is being read, indexingTEST_DATAwith the running row number. When the server returns the eight rows in a single block, the first branch runs for all eight rows and readsTEST_DATA[4..7], past the array:The values matched only because
TEST_DATA2happened to followTEST_DATAin memory, which nothing guarantees.Change: the two anonymous structs become one
Row, the expectation is the concatenation of both datasets, and every received row is compared against it withASSERT_LT(row, expected.size())instead of the branch. Block boundaries no longer matter.Checked locally against ClickHouse 26.11.1 (macOS arm64): the test passes under AddressSanitizer and UBSan with
halt_on_error=1, and the wholeClientCasesuite stays green.