docs: correct stale support claims in README - #61
Merged
Conversation
The "Not Yet Implemented" list said joins, subqueries, set operations, and JSON path translation were missing. All four are implemented and covered by tests. - Add Joins, Subqueries, and Set Operations sections. Each records the ClickHouse-specific behaviour: the automatic `join_use_nulls=1` and its `DisableJoinNullSemantics()` opt-out, the `ifNull(..., 0)` wrap for COUNT/SUM scalar subqueries, and the explicit ALL/DISTINCT modifier that ClickHouse needs for set operations. - Document JSON path querying and the seven `EF.Functions.SimpleJson*` helpers, which the README did not mention. - Replace the two incorrect "Not Yet Implemented" entries with the real gaps: server-generated values, `.ToJson()` owned entities, queries that lower to CROSS APPLY / OUTER APPLY, and set operations after a client projection. - Clarify the JSON integer-precision note, which applies to in-memory inspection and not to a translated path query. Docs only. No source changes. Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The README Not Yet Implemented list said joins, subqueries, set operations, and JSON path query translation were missing. All four are implemented and covered by tests, so the README understated the provider.
JoinAndSetOperationTests.csand the inheritedNorthwindJoinQueryRelationalTestBase/NorthwindSetOperationsQueryRelationalTestBasesuites.93fb38b.JsonNodeindexing translates to native dot and subscript syntax. Covered byJsonNodeTranslationTests.cs.Changes
join_use_nulls=1with itsDisableJoinNullSemantics()opt-out, theifNull(..., 0)wrap for COUNT/SUM scalar subqueries, and the explicitALL/DISTINCTmodifier that ClickHouse needs becauseunion_default_modeis empty.simpleJSON*. One worked example of a translated path filter, plus the sevenEF.Functions.SimpleJson*helpers, which the README did not mention at all..ToJson()owned entities, queries that EF Core lowers toCROSS APPLY/OUTER APPLY, and set operations after a client projection.JsonNodeinspection and not to a translated path query.Verification
Every added claim was checked against the source and the tests. Notable corrections made during review:
ClickHouseJsonNodeTranslatormatchesSqlConstantExpressiononly, so aWherethrows. Client evaluation is possible only in a finalSelect.Join_Local_*Collection_Workstests areContains→IN, not joins. Local-sequence joins are covered forint[]/string[]/byte[]through the Northwind base suite, so the two cases are now described separately.Includeof a collection navigation hits the APPLY limit. That was unsupported speculation and was removed.Docs only. No source changes, so no build or test impact.
🤖 Generated with Claude Code