Fix group entries of shared stacks & use countutil for badges.#196
Open
Rsslone wants to merge 5 commits intoCleanroomMC:cleanroomfrom
Open
Fix group entries of shared stacks & use countutil for badges.#196Rsslone wants to merge 5 commits intoCleanroomMC:cleanroomfrom
Rsslone wants to merge 5 commits intoCleanroomMC:cleanroomfrom
Conversation
Rsslone
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setCollapsed used a hashmap to track expanded slot membership, shared membership would overwrite previous entries and break border rendering between shared groups.
expandedElementToGroup similarly used item identity and multiple shared memberships would overwrite causing collapse actions to affect the wrong expanded groups.
Added backwards compatible overload to countutil and moved badge count to use countutil.
Let me know if there are any issues with the implementation.