New. BinaryCheck. Init module. by svfcode · Pull Request #593 · CleanTalk/security-malware-firewall

svfcode · 2026-01-20T04:17:50Z

task https://app.doboard.com/1/task/29314

…irewall into binarycheck-init

# Conflicts: # inc/spbc-backups.php

alexandergull

https://app.doboard.com/1/task/43500 - task is not ready, request a new review since it is.

Copilot

Pull request overview

This PR introduces a new “Binary analysis” scanning stage to detect and surface potentially suspicious binary/executable files, integrates it into the scanner pipeline/UI, and adds safer handling for viewing binary files in scan results.

Changes:

Added a new scanner stage (binary_analysis) with supporting storage/reporting and a binary-check module that inspects file headers.
Updated scanner queries and actions to exclude binary-tagged files from cloud send / cure / heuristic/signature flows.
Added UI/settings wiring for enabling the stage and rendering binary files as a hex dump when viewing file contents.

Reviewed changes

Copilot reviewed 12 out of 15 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
lib/CleantalkSP/SpbctWP/State.php	Adds default setting for enabling binary analysis.
lib/CleantalkSP/SpbctWP/SpbcEnqueue.php	Exposes new stage flags/translations to the frontend.
lib/CleantalkSP/SpbctWP/Scanner/Surface.php	Includes extensionless files in scan discovery (binary candidates).
lib/CleantalkSP/SpbctWP/Scanner/Stages/CureStage.php	Excludes binary-tagged files from curing selection.
lib/CleantalkSP/SpbctWP/Scanner/Services/SendFileToCloudService.php	Prevents sending binary-tagged files to cloud analysis.
lib/CleantalkSP/SpbctWP/Scanner/ScanningStagesModule/Stages/BinaryAnalysis.php	New stage data object for logging/progress.
lib/CleantalkSP/SpbctWP/Scanner/ScannerQueue.php	Adds the `binary_analysis` stage and integrates module execution + SQL filtering.
lib/CleantalkSP/SpbctWP/Scanner/ScannerActions/FileSystemActions.php	Adds hex-dump rendering when viewing binary files.
lib/CleantalkSP/SpbctWP/Scanner/ScannerActions/CloudAnalysisActions.php	Excludes binary-tagged files from bulk cloud-send selection.
lib/CleantalkSP/SpbctWP/Scanner/BinaryCheckModule/BinaryCheckModule.php	New module performing header-based binary detection and DB status updates.
js/src/spbc-scanner-plugin.js	Adds binary stage handling in the scanner frontend logic.
js/spbc-scanner-plugin.min.js	Built/minified output reflecting the new stage.
js/spbc-scanner-plugin.min.js.map	Source map updated for the new stage.
inc/spbc-settings.php	Adds the settings field and UI stage label; adjusts actions for binary files.

Comments suppressed due to low confidence (1)

lib/CleantalkSP/SpbctWP/Scanner/ScannerQueue.php:1035

source is being set to an empty string for non-binary files. This breaks logic that relies on source IS NULL to identify unknown files (e.g., UnknownRepository), and also makes later isset($file_info['source']) checks treat the source as “known”. Store NULL for non-binary files and insert SQL NULL (not an empty string) so existing unknown-file workflows keep working.

                // if extension is not set, set 'source' to 'binary'
                $file['source'] = ! $ext ? 'BINARY' : '';

                if ( ! spbc_check_ascii($file['path']) ) {
                    $sql_query__values_non_ascii[] = '(\'' . implode('\',\'', $file) . '\')';
                } else {
                    $sql_query__values[] = '(\'' . implode('\',\'', $file) . '\')';
                }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

alexander-b-clean · 2026-07-08T10:44:03Z

                if ( is_file($path) && !is_link($path) ) {
+                    $currentFileExtension = pathinfo($path, PATHINFO_EXTENSION);
+
+                    if ($currentFileExtension === '') {
+                        $this->output_counter_files++;
+                        $this->output_files[]['path'] = $path;
+                        continue;
+                    }


I think that's wrong.

What is this logic for? If you want to count no-extension files, modify the logic before extension check.

if ($currentFileExtension !== "") {
if ( $this->ext_except || $this->ext ) ...
\further extension check
}

Note, this is not the same logic as just counting files. If you skip the fie the way it is now, next iterator logic may be broken.

alexander-b-clean · 2026-07-08T11:00:19Z

+    public function run($amount = 4, $offset = 0)
+    {
+        $this->batch_count   = 0;
+        $this->scanned_count = 0;
+        $this->statuses      = array();
+
+        $binary_files      = $this->getBinaryFiles($amount, $offset);
+        $this->batch_count = count($binary_files);
+
+        $this->analyzeBinaryFiles($binary_files);
+
+        return array(
+            'success'       => true,
+            'batch_count'   => $this->batch_count,
+            'scanned_count' => $this->scanned_count,
+            'statuses'      => $this->statuses,
+        );


So please provide a new task to cover the Binary analysis with unit-test.

https://app.doboard.com/1/task/52872

alexandergull · 2026-07-08T12:14:54Z

                if ( is_file($path) && !is_link($path) ) {
+                    $currentFileExtension = pathinfo($path, PATHINFO_EXTENSION);
+
+                    if ($currentFileExtension === '') {
+                        $this->output_counter_files++;
+                        $this->output_files[]['path'] = $path;
+                        continue;
+                    }


Note, this is not the same logic as just counting files. If you skip the fie the way it is now, next iterator logic may be broken.

alexandergull · 2026-07-08T12:17:53Z

+    public function run($amount = 4, $offset = 0)
+    {
+        $this->batch_count   = 0;
+        $this->scanned_count = 0;
+        $this->statuses      = array();
+
+        $binary_files      = $this->getBinaryFiles($amount, $offset);
+        $this->batch_count = count($binary_files);
+
+        $this->analyzeBinaryFiles($binary_files);
+
+        return array(
+            'success'       => true,
+            'batch_count'   => $this->batch_count,
+            'scanned_count' => $this->scanned_count,
+            'statuses'      => $this->statuses,
+        );


So please provide a new task to cover the Binary analysis with unit-test.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…ck-init # Conflicts: # inc/spbc-settings.php

svfcode and others added 4 commits January 20, 2026 07:15

New. BinaryCheck. Init module.

2084d0d

fix phpcs

8f7dbf6

Merge branch 'dev' of https://github.com/CleanTalk/security-malware-f…

0f5fd44

…irewall into binarycheck-init

New. BinaryCheck. Edits for the new module in the scanner

b3bee64

alexandergull requested review from AntonV1211 and Glomberg February 25, 2026 11:35

AntonV1211 approved these changes Feb 26, 2026

View reviewed changes

alexandergull marked this pull request as draft February 26, 2026 13:50

Glomberg removed their request for review April 6, 2026 17:50

Glomberg and others added 3 commits April 24, 2026 17:29

Merge remote-tracking branch 'origin/dev' into binarycheck-init

b61e862

Code. BinaryCheck. Code review

0a97983

Code. BinaryCheck. Code review

4af5867

alexander-b-clean requested review from AntonV1211 and alexandergull June 17, 2026 16:45

AntonV1211 requested a review from Glomberg June 18, 2026 05:54

AntonV1211 approved these changes Jun 18, 2026

View reviewed changes

datorik added 3 commits June 19, 2026 12:14

Merge branch 'dev' into binarycheck-init

bee8ab3

# Conflicts: # inc/spbc-backups.php

Merge branch 'dev' into binarycheck-init

937fff9

Code. BinaryCheck.

39b732d

Glomberg marked this pull request as ready for review June 22, 2026 10:41

Glomberg approved these changes Jun 22, 2026

View reviewed changes

alexandergull requested changes Jun 23, 2026

View reviewed changes

datorik added 3 commits July 1, 2026 16:12

Code. BinaryCheck.

d226e5d

Code. Batch

5847e55

Code. Batch

af966f1

alexander-b-clean requested a review from Copilot July 8, 2026 06:17

Copilot started reviewing on behalf of alexander-b-clean July 8, 2026 06:17 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Code. Code review

cadec6c

alexandergull requested changes Jul 8, 2026

View reviewed changes

alexander-b-clean requested a review from alexandergull July 8, 2026 12:26

alexander-b-clean and others added 7 commits July 9, 2026 09:21

Potential fix for pull request finding

6b7075f

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

2ae9b28

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

42c9a9e

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

25d8888

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

f3c5218

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Code. Code review

daf42a4

Merge remote-tracking branch 'origin/binarycheck-init' into binaryche…

2ae70fc

…ck-init # Conflicts: # inc/spbc-settings.php

Uh oh!

Conversation

svfcode commented Jan 20, 2026

Uh oh!

alexandergull left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants