Spots page links#109
Open
veronika-tseleva-cleantalk wants to merge 8 commits into
Open
Conversation
veronika-tseleva-cleantalk
requested review from
AntonV1211,
Glomberg,
alexander-b-clean,
alexandergull,
Copilot and
svfcode
There was a problem hiding this comment.
Pull request overview
Adds “deep links” from SpotFix widget comments to a specific task comment (via URL hash), and auto-opens/scrolls the widget to that comment when the hash is present.
Changes:
- Render comment timestamps as links that include
#spotfix_comment_<taskId>_<commentId>and style them to look like plain text. - Parse URL hash changes to auto-open the widget on the referenced task/comment and scroll the comment into view.
- Adjust task ordering/scroll behavior and add minor null-safety around the wrap click handler.
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| styles/doboard-widget.css | Styles comment-time links to inherit text styling (no underline). |
| js/src/widget.js | Generates comment IDs/links and scrolls to the target comment when opened via hash. |
| js/src/main.js | Adds hash parsing and listeners (hashchange, popstate) to open the widget from deep links. |
| js/src/loaders/SpotFixTemplatesLoader.js | Wraps comment time in an anchor and adds an id for scroll targeting. |
| dist/doboard-widget-bundle.js | Bundled output reflecting the source changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/49145