Lower trans_stopped_velocity below the robot's real top speed#30
Open
MJohnson459 wants to merge 1 commit into
Open
Lower trans_stopped_velocity below the robot's real top speed#30MJohnson459 wants to merge 1 commit into
MJohnson459 wants to merge 1 commit into
Conversation
trans_stopped_velocity was 0.25 m/s, above the ~0.218 m/s ceiling the servos actually sustain, so the controller treated the robot as stopped even at full cruise — skewing the RotateToGoal "have we stopped translating yet" check. Drop it to 0.1, clearly below cruising speed. Claude-Session: https://claude.ai/code/session_01C1uzkSYe5pzhPvamaoaHcW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FollowPath.trans_stopped_velocitywas0.25m/s — above the ~0.218 m/s surface-speed ceiling the servos actually sustain at the 5 V supply (measured from recorded odometry). The controller therefore treats the robot as "stopped translating" even at full cruise, which skews the RotateToGoal critic's "have we stopped yet" check. Lower it to0.1, clearly below cruising speed.Context
Surfaced while reviewing the real-robot nav bags (the same investigation behind the WheelSpeedLimit critic, #28): the robot's linear speed is hard-walled at ~0.218 m/s, so any threshold above that is never crossed.
Test plan
nav2_params.yamlstill parses.Note
Touches the same
FollowPathblock as #28, so whichever lands second will need a trivial conflict resolution.🤖 Generated with Claude Code