ci: pass KEYCLOAK_CLIENT_SECRET to the smoke workflow - #451
Merged
Conversation
run-smoke.yml now preflights its Keycloak configuration instead of letting the authenticated API tests skip silently and the run go green on nothing. It needs the client secret to do that. `dataspace` is a confidential client, so the ROPC token request returns 401 unauthorized_client without it. The reusable workflow declares the secret optional so this repo kept parsing before this change, but api-smoke fails its preflight until the secret is passed and set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One line per call site, so
api-smokecan authenticate.Why
run-smoke.ymlnow preflights its Keycloak configuration instead of letting the authenticated API tests skip silently while the run goes green on nothing (CivicDataSpace-test#18). It needs the client secret to do that.dataspaceis a confidential client, so the ROPC token request returns401 unauthorized_clientwithout it.The reusable workflow declares the secret optional, so this repo kept parsing before this change — but
api-smokefails its preflight until the secret is both passed and set.Order of operations
KEYCLOAK_CLIENT_SECRETas a repository secret hereCIbranch)Merging this before step 1 makes
api-smokered.Touches
deploy-Dataspace.yml.Note:
promote-devis gated onsmoke-testssucceeding here, so dev promotion blocks until the secret is set.