feat(skills): add pr-review skill; copy verbatim when sources scan clean - #134
Merged
Merged
Conversation
Add skills/ess/pr-review (SKILL.md, 6 reference docs, 9 scripts) and bring the four existing skills back to parity with their source tree: - pr-address-comments now points at the pr-review skill rather than a stale /review-pr command, a reference that resolves now that pr-review ships here - summarize-change-log: correct the example to `langsmith-client deploy docker` - summarize-change-log: _REPO_ROOT was parents[5], carried over from an earlier .cursor/skills/mn/ path one level deeper. At skills/ess/<skill>/scripts/ the repo root is parents[4], so the old value resolved above the repo. Latent rather than breaking, since the tests never exercise that lookup. Also replace the 13-line appendix stub in LICENSE, at the root and in every skill, with the full Apache-2.0 text that section 4(a) requires when redistributing, and move copyright attribution to a root NOTICE per 4(d).
Phase B handed every sync to the primary agent, including sources the scanners had already cleared. With no jargon to generalize the agent paraphrases working prose instead: on a 16-file skill directory it rewrote all 16 files and 187 lines, replacing a live sibling-skill reference and a named tool with vague descriptions, and swapping one table row for unrelated content. Skip the agent when --no-extract is set and the source pre-scan is empty, and copy the tree instead. The copy still faces the deterministic scanners and the adversarial reviewer, and escalates to the agent if either raises anything critical, so the safety bar is unchanged. The reviewer was always a detector; only the primary agent rewrote, and it did so unconditionally. Same run before and after: 11min with 187 changed lines, versus 27s with zero drift. The copy honors .gitignore and the scanners' skip list, which is a safety property rather than an optimization: the scanners never read gitignored paths, so copying them would ship content nothing vouched for, .env being the obvious hazard. Files copied but unreadable by the text scanners, binaries and anything past the size cap, are reported at the end of the run. Target-only files such as LICENSE and NOTICE are left alone so a re-sync cannot clobber them. Add --no-fast-copy to force the agent path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two commits.
feat(skills)— addsskills/ess/pr-review(SKILL.md, 6 reference docs, 9 scripts) and brings the four existing skills back to parity with their source tree:pr-address-commentsnow points at thepr-reviewskill instead of a stale/review-prcommand, a reference that resolves now thatpr-reviewships here.summarize-change-logexample corrected tolangsmith-client deploy docker.summarize-change-log_REPO_ROOTwasparents[5], carried over from an earlier.cursor/skills/mn/path one level deeper. Atskills/ess/<skill>/scripts/the repo root isparents[4], so the old value resolved above the repo. Latent rather than breaking, since the tests never exercise that lookup.Also replaces the 13-line appendix stub in
LICENSE, at the root and in every skill, with the full Apache-2.0 text that §4(a) requires when redistributing, and moves copyright attribution to a rootNOTICEper §4(d).perf(essentials-sync)— Phase B handed every sync to the primary agent, including sources the scanners had already cleared. With no jargon to generalize the agent paraphrases working prose instead: on this very skill directory it rewrote all 16 files and 187 lines, replacing a live sibling-skill reference and a named tool with vague descriptions, and swapping one table row for unrelated content.Now, when
--no-extractis set and the source pre-scan is empty, the tree is copied verbatim. The copy still faces the deterministic scanners and the adversarial reviewer, and escalates to the agent if either raises anything critical, so the safety bar is unchanged — the reviewer was always a detector; only the primary agent rewrote, and it did so unconditionally. Same run before and after: 11min with 187 changed lines, versus 27s with zero drift.The copy honors
.gitignoreand the scanners' skip list. That is a safety property rather than an optimization: the scanners never read gitignored paths, so copying them would ship content nothing vouched for,.envbeing the obvious hazard. Files copied but unreadable by the text scanners (binaries, anything past the size cap) are reported at the end of a run, and target-only files such asLICENSE/NOTICEare left alone so a re-sync cannot clobber them.--no-fast-copyforces the agent path.Test plan
diff -rqbetween the source tree andskills/ess/reports only the intentional target-onlyLICENSEfilestest_report.py14,test_validate_summary.py10); allpr-reviewshell scripts passbash -n100755in gitskills/ess/__pycache__or.pyccommittedLICENSEfiles byte-identical to canonical Apache-2.0 (md53b83ef96387f14655fc854ddc3c6bd57)essentials-syncsuite 21 -> 33 tests;tsc --noEmitclean--dry-runonpr-reviewproduces output byte-identical to the source with matching exec bits