feat: long-press back button on MainMenu to delete a book with confirmation#32
Closed
illiaboyko wants to merge 2 commits into
Closed
feat: long-press back button on MainMenu to delete a book with confirmation#32illiaboyko wants to merge 2 commits into
illiaboyko wants to merge 2 commits into
Conversation
Owner
Author
|
fair enough! |
Contributor
|
Thank you very much for this idea, @illiaboyko. Based on this need, I've implemented it in my fork https://github.com/pablohc/microreader/tree/feat/delete-file |
Author
|
ah, lovely job @pablohc, thanks a lot! i'm not a developer at all, but if you or any contributors/maintainers ever get around to wifi implementation, i would be happy to help with the web ui if needed |
Contributor
|
@illiaboyko improvement submitted to upstream: #41 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This is a small feature borrowed from crosspoint; it lets you long-press a book title for 800ms to enter a deletion dialogue. The "Microreader" header turns into "Delete?" and book title turns into "Back=No Sel=Yes " instructions. If confirmed it deletes both EPUB and MRB from library.
As someone who reads a lot of articles on the device I found it quite handy, hope it works for more people.