fix chunk_table row traversal and update pgrx to 0.19.2 - #278
Open
Vonng wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chunk_tablereads at most one tuple withSpi::get_two, so it reports success while silently omitting subsequent source rows. Iterate the full SPI result through a mutable connection, preserving the existing chunking and transactional insertion behavior. Empty inputs now create an empty output table instead of raising an SPI positioning error.Pin
pgrxandpgrx-teststo=0.19.2, check in the extension-localCargo.lock, and declare Rust 1.96 as the minimum version. Remove the obsolete embed binary declaration and source, which use the removedpgrx_embed!macro. The SQL/control version remains 0.23.0.The CI follow-up fixes three failures observed on this PR:
test_staticfixture using the local embedding service, and verify its retained embeddings and search afterALTER EXTENSIONbefore the regular tests recreate the extension.test_table_fromcrossed a minute boundary: its active cron job correctly processed the third row while the test expected two. Register and pause that cron job in one transaction, and poll for the realtime worker result with a timeout.Validation:
--release --no-default-features --features pg17 --locked --offline; executedtest_chunk_tableandtest_table_from. A deterministic local embedding stub delayed the realtime response across an actual minute boundary; both tests passed. This tests scheduling and row counts, not model quality.Fixes #277