Open
Conversation
Naitbit
requested changes
Mar 3, 2025
Member
Naitbit
left a comment
Naitbit
left a comment
There was a problem hiding this comment.
Supporting old devices was intentional. Abandoning some of our users should have a good reason.
Opting in into vector drawable changes without actual vector drawable changes looks like something that would require QA pass for no improvement in user experience.
Prougard optimizations were skipped as we tried to keep dependencies and code size to a minimum to not need.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here’s what I fixed:
Added applicationId – Ensures a unique app identifier.
Increased minSdkVersion from 16 to 21 – Improves security and compatibility.
Enabled vectorDrawables.useSupportLibrary – Allows vector drawables on older Android versions.
Optimized ProGuard settings – Switched to proguard-android-optimize.txt for better performance and enabled shrinkResources to reduce APK size.
Used JavaVersion.VERSION_1_8 – Instead of string literals, ensuring better code practices.
These changes make the project more optimized and future-proof.