Skip to content

Sdk/local main consolidation - #85

Merged
AriusII merged 9 commits into
mainfrom
sdk/local-main-consolidation
Sep 22, 2026
Merged

AriusII merged 9 commits into
mainfrom
sdk/local-main-consolidation

Conversation

@AriusII

@AriusII AriusII commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Outcome and linked issue

Closes

Scope and architectural ownership

Describe resulting behavior, affected contracts, and exclusions. SDK owns CE integration; Client owns workflows and
policy.

Dependencies and containing artifacts

Link upstream prerequisites without closing them. Identify the SDK package containing every consumed primitive.

Validation actually performed

Check Command / profile Actual result Evidence
Unit / fixture Not executed
Packed consumer Not executed
Live host Not executed
AOT publication Not executed

Compatibility, lifetime and partial effects

Explain public API or behavior changes, ownership, target switches, cleanup, cancellation and migration.

Documentation and review checklist

  • Scope is focused; existing repository style and contribution rules are preserved.
  • Relevant regression evidence is attached; pending gates remain explicit.
  • Ownership, provenance, and raw-state exposure match the supported consumer boundary of the affected layer.
  • Capability and artifact claims match actual results.
  • Documentation and release impact are recorded.
  • No automatic merge, release, protection change or unsupported capability activation is requested.

Add a pinned dependency-review job to the reusable CI workflow for non-draft pull requests. Include its result in the gate summary and require it only when the job is expected to run, so push and draft workflows remain valid while high-severity dependency changes fail the PR gate.
…place `Volatile` with `System.Threading.Volatile` static usage for Lua runtime lifecycle operations.
Restore the ABI alignment probe prefix so native MSVC fixture facts match managed x64 measurements. Align Lua annotation tests and documentation with the intentional framework-default inheritance contract. Make dependency review opt-in until GitHub Dependency graph is enabled, keep it blocking when enabled, and upgrade the pinned action to v5.
Delete the Sonar reusable workflow and remove its secret, coverage, and gate wiring from the base CI path. Keep pull requests focused on the repository-owned build, tests, packaging, Native AOT, dependency review, workflow lint, and final gate. Remove the now-unused Microsoft Testing Platform coverage extension and align CodeRabbit workflow guidance with the remaining pipeline.
Build and test the solution once per configuration, pack the tested Release build, reuse the native bridge, ABI facts and coverage artifacts, restore the Sonar token with fork and Dependabot guards, run actionlint on every event, and evaluate the gate generically over all jobs.
Release the nuget-package artifact built and tested on the tag, behind the nuget environment approval, with CHANGELOG release notes, a nuget.org duplicate guard and attestation after the push.
Use the assertive profile with advisory pre-merge checks, simplify the pull request template, and describe the CI, squash merges and releases in CONTRIBUTING.
@AriusII
AriusII merged commit a56b6c1 into main Sep 22, 2026
5 of 7 checks passed
@AriusII
AriusII deleted the sdk/local-main-consolidation branch September 22, 2026 18:56
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: CheatEngineNet/CheatEngine.SDK/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 08d4bebb-12f4-4e2e-99f3-eea3473c90f3

📥 Commits

Reviewing files that changed from the base of the PR and between e5e952f and e40c99f.

📒 Files selected for processing (25)
  • .coderabbit.yaml
  • .github/PULL_REQUEST_TEMPLATE.md
  • .github/workflows/ci.yml
  • .github/workflows/main-ci.yml
  • .github/workflows/pull-request-ci.yml
  • .github/workflows/release.yml
  • .github/workflows/sonar.yml
  • AGENTS.md
  • CONTRIBUTING.md
  • CheatEngine.SDK.slnx
  • Directory.Packages.props
  • RELEASING.md
  • eng/Tests.props
  • libs/CheatEngine.SDK.Abi/README.md
  • libs/CheatEngine.SDK.Annotations/Lua/LuaClassAttribute.cs
  • libs/CheatEngine.SDK.Annotations/Lua/LuaMarshallerAttribute.cs
  • libs/CheatEngine.SDK.Annotations/Lua/LuaPropertyAttribute.cs
  • libs/CheatEngine.SDK.Engine/AddressList/AddressListMutations.cs
  • libs/CheatEngine.SDK.Engine/Inspection/SymbolRegistry.cs
  • libs/CheatEngine.SDK.Engine/Scanning/Values/MemoryScanSession.cs
  • libs/CheatEngine.SDK.Lua/Runtime/LuaRuntime.cs
  • tests/CheatEngine.SDK.Abi.Tests/README.md
  • tests/CheatEngine.SDK.LiveProbe/LiveProbeAuthorization.cs
  • tests/CheatEngine.SDK.SourceGenerators.LuaBindings.Tests/Generator/LuaObjectOutputTests.cs
  • tests/native-abi-fixture/README.md

Warning

This pull request changes a CodeRabbit configuration file. Because it comes from a fork or its author is not a repository collaborator, reviews use only the configuration from the target branch. The proposed configuration will take effect after it is merged.


Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant