Remove SonarCloud CI integration - #56
Merged
Merged
Conversation
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
Limit details: You’ve used all 10 included reviews currently available. 📝 WalkthroughWalkthroughThe pull request removes SonarQube Cloud jobs from the main and pull-request CI workflows and deletes the reusable SonarQube Cloud workflow. ChangesSonar workflow removal
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Removes the complete SonarQube Cloud integration so PRs and
mainno longer schedule a Sonar analysis or wait on a Sonar quality gate.Technical scope
.github/workflows/sonar.ymlworkflow, including scanner installation, Sonar token use, coverage collection, analysis upload, and quality-gate wait.sonarjob, its secret dependency, and its conditional execution from both PR andmainorchestration workflows.Validation
git diff --checkactionlint1.7.12 downloaded with the repository-pinned SHA-256sonar/sonarcloud(excluding Git metadata and build output)CI,Lint workflows,Validate packages, template, and AOT graph, andGateremainNo production code, package metadata, test configuration, or CI validation step was changed.
Summary by CodeRabbit