Follow-up to #41: correct CLI-PLAN receipt and validate roadmap hierarchy

[AriusII]

Follow-up to #41

This focused follow-up corrects the two planning-governance findings on the merged roadmap bootstrap. It contains no Cheat Engine runtime implementation, package publication, release-policy change, Project mutation, or live-host qualification claim.

Changes

• Records the temporal deployment receipt for CLI-PLAN: the initial integration write was denied, while the later operator-authorized import created and populated private Project Establish public client contracts and build foundation #1 and Client issues #8–#40. The local work-item document, manifest evidence, and future-import body template now agree.
• Makes the manifest hierarchy a validated tree: exactly one roadmap root; roadmap children are epics; every epic is directly under the root; each implementation leaf belongs directly to its epic and has no children; parent cycles, duplicate children, disconnected forests, and reciprocal-link violations fail with explicit ValueError messages.
• Adds positive and negative Python coverage for the checked-in manifest, parent cycles independent of blocked_by, a second roadmap, disconnected hierarchy, invalid root child, nested epic, and nested leaf.

Validation evidence

• python -B -m unittest eng.tests.test_validate_engineering_manifest — 12 tests passed.
• python -B eng/Validate-EngineeringManifest.py --repository-root D:\CheatEngine\worktrees\client-quality-roadmap — 33 work items, 7 milestones, 25 external dependencies, and the 36-finding/80-scenario archive reconciliation validated.
• The same unit and manifest commands passed under python -B -O; python -B -m json.tool docs/engineering/backlog.json and git diff --check also passed.

The architecture-review archive remains bounded planning context. The receipt distinguishes metadata deployment from source, package, fixture, implementation, and live-host evidence.

Summary by CodeRabbit

• Bug Fixes

  • Strengthened engineering manifest validation to detect parent cycles, disconnected items, invalid hierarchy relationships, and multiple roadmap roots.
  • Enforced the expected roadmap, epic, and implementation-item structure before dependency checks run.

• Documentation

  • Clarified planning records to distinguish authorized project and issue setup from implementation verification.
  • Added qualifications that planning receipts do not confirm packages, fixtures, or live-host readiness.

• Tests

  • Added coverage for invalid parent hierarchies, including cycles, disconnected structures, and incorrectly nested items.

[coderabbitai]

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 88b02ac2-7e60-4b14-9ecf-db63140c5733

📥 Commits

Reviewing files that changed from the base of the PR and between 02077c0 and 6632c5c.

📒 Files selected for processing (4)

• docs/engineering/backlog.json
• docs/engineering/work-items/CLI-PLAN.md
• eng/Validate-EngineeringManifest.py
• eng/tests/test_validate_engineering_manifest.py

Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The manifest validator now enforces a connected, acyclic roadmap hierarchy before dependency checks. Tests cover invalid hierarchy structures. CLI planning evidence now records authorized project and issue creation with explicit qualification limits.

Changes

Manifest hierarchy validation

Layer / File(s)	Summary
Centralized hierarchy validation eng/Validate-EngineeringManifest.py	Added cycle, connectivity, root, parent-child, type, duplicate-child, and leaf validation. The centralized validation runs before dependency processing.
Hierarchy validation tests eng/tests/test_validate_engineering_manifest.py	Added tests for invalid cycles, roots, connectivity, child types, epic parents, and implementation leaves.

CLI planning evidence

Layer / File(s)	Summary
Planning evidence qualification docs/engineering/backlog.json, docs/engineering/work-items/CLI-PLAN.md	Updated planning evidence to record denied preparation, authorized project and issue creation, and limits on implementation and qualification claims.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 35.71% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 2 files. (2 skipped: …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies both main changes: correcting the CLI-PLAN receipt and validating the roadmap hierarchy. It is concise and specific.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 35.71% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 2 files. (2 skipped: 2 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}