Skip to content

Separate capability implementation, host evidence, and policy - #48

Merged
AriusII merged 1 commit into
mainfrom
feat/cli-002-capability-evidence-model
Sep 21, 2026
Merged

AriusII merged 1 commit into
mainfrom
feat/cli-002-capability-evidence-model

Conversation

@AriusII

@AriusII AriusII commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • add a small immutable capability-evidence model with separate implementation, package, host, live-qualification, policy, and activation-lifetime gates
  • classify missing globals, host faults, and malformed host values independently; policy opt-in for unsafe Lua no longer manufactures host evidence
  • align unavailable-adapter reasons, public API baseline, focused contract/runtime/DI tests, and capability documentation

Validation

  • dotnet build CheatEngine.Client.slnx --configuration Release --no-restore --warnaserror (0 warnings, 0 errors)
  • targeted Abstractions tests: 186/186 passed
  • targeted Core tests: 249/249 passed
  • targeted DI tests: 24/24 passed
  • Native AOT probe publish (win-x64) passed

The full solution test command executed 539 tests; 538 passed. The remaining failure is the existing source-generator snapshot newline mismatch (CRLF expected versus LF generated), outside this PR's changed files.

No live Cheat Engine host was run. Live qualification is intentionally reported as unknown until its opt-in qualification gate is completed.

Closes #18

Summary by CodeRabbit

  • New Features

    • Added detailed capability status reporting across implementation, package support, host availability, live qualification, policy, and activation lifetime.
    • Capability results now distinguish available, unavailable, unknown, faulted, and malformed states with explanatory reasons.
    • Added execution eligibility reporting for capabilities.
  • Bug Fixes

    • Improved runtime validation for versions, process identifiers, architecture, and activation state.
    • Probe failures now identify missing globals, unsupported capabilities, malformed results, and runtime faults separately.
    • Unsafe Lua activation no longer implies broader capability support or qualification.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: bc67343d-c4dd-4539-8e19-74f1d583bb48

📥 Commits

Reviewing files that changed from the base of the PR and between 070802d and a2748f6.

📒 Files selected for processing (14)
  • docs/adr/0004-capability-matrix.md
  • libs/CheatEngine.Client.Abstractions/PublicAPI.Unshipped.txt
  • libs/CheatEngine.Client.Abstractions/README.md
  • libs/CheatEngine.Client.Abstractions/Runtime/ClientCapabilities.cs
  • libs/CheatEngine.Client.Abstractions/Runtime/ClientCapabilityAvailability.cs
  • libs/CheatEngine.Client.Abstractions/Runtime/ClientCapabilityEvidence.cs
  • libs/CheatEngine.Client.Abstractions/Runtime/ClientCapabilityEvidenceGate.cs
  • libs/CheatEngine.Client.Abstractions/Runtime/ClientCapabilityEvidenceState.cs
  • libs/CheatEngine.Client.Core/Domains/Events/UnavailableCapabilityFailure.cs
  • libs/CheatEngine.Client.Core/Domains/ProbeResult.cs
  • libs/CheatEngine.Client.Core/Domains/RuntimeClient.cs
  • libs/CheatEngine.Client.Extensions.DependencyInjection/README.md
  • tests/CheatEngine.Client.Abstractions.Tests/Runtime/ClientCapabilitiesTests.cs
  • tests/CheatEngine.Client.Core.Tests/Domains/RuntimeClientTests.cs
 ____________________________________________
< This is what it sounds like when bugs cry. >
 --------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@AriusII
AriusII merged commit 2d8c894 into main Sep 21, 2026
4 of 5 checks passed
AriusII added a commit that referenced this pull request Sep 21, 2026
…on-code

Follow-up to #48/#18: Expose structured capability evidence reason code
@AriusII
AriusII deleted the feat/cli-002-capability-evidence-model branch September 21, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant