Repository navigation
Bound event consumers and specify stream completion - #45
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #35.
MoveNextAsyncon enumerator disposal, so a disposed reader cannot absorb a later observation;DroppedEventCount.Contract
IEventStreamLease<TEvent>.Eventsis a bounded unicast work queue, not a broadcast subscription. Callback admission never waits for reader consumption or reader continuations, but the implementation honestly remains lock-protected rather than lock-free.Complete()drains accepted observations; terminal failure and internal stream abort discard buffered observations and record that loss. The currently unavailable debugger/hotkey/timer/DBVM producers remain unavailable: this PR does not claim live Cheat Engine callback qualification.Validation
dotnet restore .\\CheatEngine.Client.slnx --locked-modedotnet build .\\CheatEngine.Client.slnx --configuration Release --no-restore— passed, 0 warnings / 0 errors.CheatEngine.Client.Core.Tests— 233 passed.CheatEngineLuaGeneratorTests.ModuleAdapterSnapshotUsesOneAdmittedOperationAndPreflightsEveryExport: expected CRLF snapshot versus generated LF output. This is unrelated to the event-stream files and reproduces from the baseline.Scope / limits
No public signatures, SDK ABI, native callback producer, or CE live claim changed. Producer callback/ABI qualification and measured host latency remain gated follow-up work.
Summary by CodeRabbit
Documentation
Behavioral Improvements