Repository navigation
Align process failures with dispatcher semantics - #43
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TargetNotAttached, inconsistent metadata asInvalidHostResult, and an attach selecting another PID asOperationRejectedTry...contractsEvidence
This resolves the Client-side R02/R03 mismatch from the architecture review. The focused tests cover PID zero, a process disappearing before refresh and after attach, inconsistent metadata, selected-PID mismatch, cancellation before dispatch admission, and exception identity preservation.
Validation
dotnet restore CheatEngine.Client.slnx --locked-modedotnet build CheatEngine.Client.slnx --configuration Release --no-restore— 0 warnings, 0 errorsdotnet test --project tests\CheatEngine.Client.Core.Tests\CheatEngine.Client.Core.Tests.csproj --configuration Release --no-build— 233 passeddotnet test --solution CheatEngine.Client.slnx --configuration Release --no-build— 515 passed; one pre-existing SourceGenerator snapshot failure remains (expected CRLF versus actual LF inModuleAdapterSnapshotUsesOneAdmittedOperationAndPreflightsEveryExport), outside this PRScope and limits
These are deterministic managed compositions, not live Cheat Engine qualification. No target identity guarantee, automatic retry, SDK ABI mapping, or CLI-021 stale-client policy is introduced.
Closes #20
Summary by CodeRabbit
Bug Fixes
Documentation