Skip to content

feat!: error on non-DSL pub fn in exportModule #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nazarhussain merged 2 commits into from
May 26, 2026
+1 −1
Merged

feat!: error on non-DSL pub fn in exportModule #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef1a348
feat: warn when dsl incompatible functions are skipped
spiral-ladder May 22, 2026
5b585bb
fix: use the compile time error
nazarhussain May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/js/export_module.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ fn registerDecls(comptime Module: type, env: napi.Env, module: napi.Value, compt
}
break :blk true;
};
if (!is_dsl_fn) continue;
if (!is_dsl_fn) @compileError("zapi: cannot export non-DSL `pub fn " ++ @typeName(Module) ++ "." ++ decl.name ++ "` — use DSL params (e.g. `js.Number`), drop `pub`, or pass `.register` to `exportModule` to export it manually");

// DSL function — wrap and register
const cb = wrap_function.wrapFunction(field);
Expand Down
Loading