Skip to content

bridge-monitor: slippage pulse gated on a quote existing, not on a positive quoted fee #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Sep 19, 2026
+5 −1
Merged

bridge-monitor: slippage pulse gated on a quote existing, not on a positive quoted fee #2537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion harnesses/bridge-monitor/cmd/monitor/executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,7 +1053,11 @@ func (e *Executor) recordExecutionMetrics(result *ExecutionResult) {
// it would inject spurious 0 / negative samples into the realized-cost bench.
// Slippage is only meaningful against a quoted fee; Near Intents used to
// publish its whole realized fee here (QuoteFeeUSD was never set).
if result.Success && result.RealizedOnChain && result.QuoteFeeUSD > 0 {
// Gate on "a quote existed", not on "the quoted fee is positive": a
// quote that promises the full ticket back (Mobula Sol to Base quoted
// $3.0000 out of $3) has a quoted fee of exactly zero, and its slippage
// (+$0.003 realized) is the most honest row on the page.
if result.Success && result.RealizedOnChain && result.QuotedOutputUSD > 0 {
pulse(bridgeQuoteSlippageUSD, labels, result.ActualFeeUSD-result.QuoteFeeUSD)
}
if result.ExecGasUSD > 0 {
Expand Down
Loading