Skip to content

Conversation

@brhat
Copy link
Collaborator

@brhat brhat commented Jul 10, 2020

This pull request contains all scripts for automated tests and the program checkBitSize, which is also used by the tests.

Copy link

@dustsigns dustsigns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request.

General remarks regarding the pull request:

  • When merging (after approval), please use a squash merge (so that the individual commits are no longer visible)

General remarks regarding documentation:

  • Please use URL formatting like DataCompressor
  • Please format file names and code-like portions as source code
  • Please fix casing of proper names and abbreviations, e.g., "TLS" instead of "tls", "Web" instead of "web" etc. This also applies to source code comments as well as input/output strings.
  • Please fix casing at the beginning of sentences -- The first word of each sentence or item (in an itemization) should be upper case. . This also applies to source code comments as well as input/output strings
  • Please add proper links for references. This applies to all file and folder references

You can find more detailed remarks as single comments within this review of the pull request. Please reply to them and add a new commit to this pull request to update it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants