[ENG-10340] Check for flag#11792
Open
bodintsov wants to merge 3 commits into
Open
Conversation
bodintsov
force-pushed
the
fix/use-account-get-disabled
branch
from
341cbde to
26e58cf
Compare
bodintsov
force-pushed
the
fix/use-account-get-disabled
branch
from
26e58cf to
4c6cf27
Compare
brianjgeiger
reviewed
Jul 2, 2026
| return False | ||
|
|
||
| text = name_content.lower() | ||
| if any(suffix in text for suffix in ['m.sc.', 'msc.', 'phd.', 'ph.d.', 'msc.pt', 'pt.', 'prof.', 'dr.', 'md.', 'jd.', 'esq.']): |
Collaborator
There was a problem hiding this comment.
This is far too specific and only handles the cases we know of, not the potential future cases. I think we need to adjust the DOMAIN_REGEX to be better (it should grab complete URLs), and also maybe if the domain regex finds something, pass the suspected domain through urllib.parse.urlsplit to see if it has a scheme and a netloc. If it doesn't have both of those, we could probably return false, since it won't link in an email to a location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-10340
Purpose
Fix the user's account getting disabled
Changes
Added a check for the frag in the method
Side Effects
TBD
QE Notes
TBD
CE Notes
TBD
Documentation
TBD