[ENG-9918] fix: cap length for iri_values doc id#890
Merged
aaxelb merged 1 commit intoCenterForOpenScience:developfrom Dec 8, 2025
Merged
[ENG-9918] fix: cap length for iri_values doc id#890aaxelb merged 1 commit intoCenterForOpenScience:developfrom
aaxelb merged 1 commit intoCenterForOpenScience:developfrom
Conversation
elasticsearch document ids may only be 512 bytes long, but the id used for trovesearch_denorm's iri_values index uses a base64-encoded url that may be longer -- use a hash instead
mfraezz
approved these changes
Dec 8, 2025
aaxelb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elasticsearch document ids may only be 512 bytes long, but the id used for documents in
trovesearch_denorm'siri_valuesindex uses a base64-encoded url that may be longer -- use a hash insteadnote: this should be safe to change in-place, because old
iri_valuesdocuments are deleted bytask__delete_iri_value_scrapsbased on theirchunk_timestamp-- this was intended for catching values removed from a later version of a metadata record, but in this case the same logic will also clean upiri_valuesdocuments using the older base64 id