Modified Dockerfile for Centos Wordpress#76
Conversation
procrypt
force-pushed
the
centos_wordpress
branch
from
8db79ac to
f956ccb
Compare
|
hey abhishek, I think this mostly looks good. I was able to use it with mariadb pulled from centos. i will do some more testing with atomicapp and see if it works with atomicapp as well. Also please update the README. Making it look very similar to https://github.com/CentOS/CentOS-Dockerfiles/blob/master/etherpad/README.md would probably be best. |
|
Tested with atomicapp - needs a few tweaks, but works fine. |
|
please update the readme and then we can merge soon after |
|
@dustymabe Sure i'll make the changes. |
| /'AUTH_SALT'/s/put your unique phrase here/`pwgen -s -1 65`/ | ||
| /'SECURE_AUTH_SALT'/s/put your unique phrase here/`pwgen -s -1 65`/ | ||
| /'LOGGED_IN_SALT'/s/put your unique phrase here/`pwgen -s -1 65`/ | ||
| /'NONCE_SALT'/s/put your unique phrase here/`pwgen -s -1 65`/" /var/www/html/wp-config-sample.php > /var/www/html/wp-config.php |
There was a problem hiding this comment.
hey @abhi1004 can we actually use openssl here instead of pwgen so that we don't have to install the epel repo.
here is an example of how to do this: https://github.com/dustymabe/summit-2016-container-lab/blob/master/labs/lab3/wordpress/scripts/config_wordpress.sh#L27-L31
Updated README.md file for PR CentOS#76
procrypt
force-pushed
the
centos_wordpress
branch
2 times, most recently
from
6bac9cd to
f5722db
Compare
|
@dustymabe if you're good with this, let me know so I can merge it in. |
|
hey @procrypt - just update the README and we'll merge. Just start from scratch on the README and follow something like what is done here: https://github.com/CentOS/CentOS-Dockerfiles/blob/master/etherpad/README.md |
|
@dustymabe Similar README file is already there. |
|
@procrypt you need to add the changes to this PR. This is what is in this PR: https://github.com/CentOS/CentOS-Dockerfiles/tree/f5722db6eefa45d7a1cf663e636474b9aa681cab/wordpress/centos7 |
|
@dustymabe There is already a PR for the changes you asked, #81 |
procrypt
force-pushed
the
centos_wordpress
branch
from
f5722db to
4f69cf4
Compare
|
@dustymabe Sorry I didn't understand what you were saying before, I have added the README to this PR. |
|
hey @jperrin merge away if you can edit the title and remove "[WIP]" first that would be great |
jperrin
changed the title
|
ping @jperrin merge! :) |
|
I'll pull it down and test/merge in a moment. started it yesterday and got dragged off for other tasks. |
|
There's only one minor nit here, and it's in the README. It contains directions for viewing/exposing 8080, but the container itself listens on port 80, so following the directions verbatim doesn't work. It's a minor change, so I'll correct it once it's merged in. |
3 participants
Fix #74,
CC @dustymabe