Skip to content

Conversation

@Amit-Matth
Copy link
Contributor

@Amit-Matth Amit-Matth commented Jun 29, 2025

PAINTROID-794

New Features and Enhancements

  • Improved the color picker with support for HSV, RGB, and color wheel models.
  • Introduced a segmented control to switch between picker types.
  • Added support for recent colors.

Refactorings and Bug Fixes

  • Sync current color and opacity across all color picker types.

Checklist

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Add the link to the ticket in Jira in the description of the PR
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines (Wiki)
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Add new information to the Wiki

@bakicelebi
Copy link
Contributor

Hi Amit, great work!

But there is a small bug with the transparency slider. When switching colors it resets back to 1. Also the 100% opaque is not really 100% left on the slider which is weird because the color under slider is transparent but its actually 100% opaque.

image

Also cancel and apply buttons should not be inside scroll view. They should always be visible to tap on.

@Amit-Matth Amit-Matth requested a review from bakicelebi July 7, 2025 12:23
@juliajulie95
Copy link
Contributor

Works great, thank you!
Please check the comments I added so we can merge it soon! :)

@Amit-Matth
Copy link
Contributor Author

I implemented the requested changes.

@juliajulie95
Copy link
Contributor

Thank you for your work!

@juliajulie95 juliajulie95 merged commit 2de1192 into Catrobat:develop Oct 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants