feat: split complex loyaltyCardViewActivity#3072
Open
NightShiftNexus wants to merge 4 commits intoCatimaLoyalty:mainfrom
Open
feat: split complex loyaltyCardViewActivity#3072NightShiftNexus wants to merge 4 commits intoCatimaLoyalty:mainfrom
NightShiftNexus wants to merge 4 commits intoCatimaLoyalty:mainfrom
Conversation
Member
|
That's a lot of changes, will take me a while to review. I must say though that I'm not a fan of the amount of removed comments. Many of these comments were added to explain not clearly obvious stuff, like " // Detect square-ish screens like the Unihertz Titan". Can you please restore the comments? |
Author
|
@TheLastProject Very good point, I have restored the comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First part of #2483 - LoyaltyCardViewActivity
This refactor reduces the complexity of LoyaltyCardViewActivity by splitting it along responsibility boundaries rather than into separate normal and fullscreen activities. In the current implementation, fullscreen is still part of the same screen flow: it uses the same card data, the same image navigation, the same actions, and the same lifecycle context.
Creating a second activity for fullscreen would therefore introduce additional state passing and coordination without addressing the real source of complexity.
Instead, the activity was simplified by extracting focused parts of its behavior into smaller, self-contained collaborators. This keeps a single entry point for the screen while making the overall structure easier to understand, maintain, and extend. In my opinion it's better way to reduce current complexity.