Adds default currency feature #2972
Closed
+99
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLastProject
requested changes
Jan 19, 2026
Member
TheLastProject
left a comment
TheLastProject
left a comment
There was a problem hiding this comment.
Didn't do a full depth review but I see multiple severe bugs. Please make sure to test your implementation well.
app/src/main/java/protect/card_locker/preferences/Settings.java
Outdated
Show resolved
Hide resolved
- Correctly assigned symbols to currency codes for respectively entries and entrieValues - Removed hardcoded string "Points" - Only select default currency at the creation of a new card (when its required field is empty)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #2886