Repository navigation
Wip/mark mismatch - #3359
Merged
Merged
Wip/mark mismatch#3359
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Preview users still resolve against an enrolling-only pool, allowing /assign and /mark to disagree.
Review effort: Balanced
Findings: 1
What changed in this PR
Aligns /mark experiment resolution with /assign for transitive decision-point pools.
Changes:
- Resolves marks using the complete context pool.
- Adds regression coverage for shared decision points.
| File | Description |
|---|---|
ExperimentAssignmentService.ts |
Uses context-wide pooling before matching the marked decision point. |
ExperimentAssignmentService.test.ts |
Tests assignment/mark consistency across connected pools. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
danoswaltCL
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.