Merged
Conversation
linguini1
requested changes
Mar 23, 2025
Collaborator
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
I would prefer that the data be transmitted in Teslas (or some variant, like microteslas) as this is the SI unit for magnetic fields and the same unit used by the uORB framework. Doing it in gauss requires an extra conversion, and is less common in general. I also don't think we should base the packet format around the specific sensors we have this year (although I know it's currently practical).
Contributor
Author
|
I also changed the numbering for the types - 0x05 wasn't being used which was a little odd, may as well fix that while we're updating the packet spec on the telem app and groundstation |
linguini1
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a magnetic field block that is essentially the same as the acceleration block. Units are in milligauss as that's roughly the sensitivity of the magnetometer we're using.