Remove MapToAmount (issue #9739)#9744
Open
kojotak wants to merge 16 commits intoCard-Forge:masterfrom
Open
Conversation
Contributor
|
was a bit too early, i wanted to refactor some of the stuff anyway, see #9747 |
kojotak
force-pushed
the
9739_MapToAmount
branch
from
2dff187 to
5166f39
Compare
…' into 9739_MapToAmount # Conflicts: # forge-game/src/main/java/forge/game/combat/AttackConstraints.java # forge-game/src/main/java/forge/game/combat/GlobalAttackRestrictions.java
Contributor
Author
|
I've merged #9747 here, so there should be no conflict afterwards |
tool4ever
reviewed
Feb 14, 2026
forge-game/src/main/java/forge/game/combat/AttackRequirement.java
Outdated
Show resolved
Hide resolved
Contributor
|
@tool4ever i want to change the playerRequirements into a |
Hanmac
reviewed
Feb 15, 2026
forge-game/src/main/java/forge/game/combat/AttackConstraints.java
Outdated
Show resolved
Hide resolved
Removed unused mapToAmount method from AttackConstraints.
Contributor
|
@Hanmac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple replacement of MapToAmount to Map<T, Integer>.
This is my first pull request, so it lacks any game logic optimalization. It just removes the MapToAmount, utils and both implementations.