Add logic so that the AI will play Sylvan Library#9738
Open
marthinwurer wants to merge 5 commits intoCard-Forge:masterfrom
Open
Add logic so that the AI will play Sylvan Library#9738marthinwurer wants to merge 5 commits intoCard-Forge:masterfrom
marthinwurer wants to merge 5 commits intoCard-Forge:masterfrom
Conversation
tool4ever
reviewed
Feb 13, 2026
| } | ||
|
|
||
| @Test | ||
| public void testSylvanLibraryCanBeCast() { |
Contributor
There was a problem hiding this comment.
this test is close to useless
Contributor
Author
There was a problem hiding this comment.
This was originally added because the AI wouldn't cast it at all because of the AI:RemoveDeck option in the card file. I can remove it entirely or add it to the other test, but it's not entirely useless because the previous behavior was just not casting it at all.
Contributor
There was a problem hiding this comment.
yea that's the intended behaviour
I don't think we'll need a test to confirm that for every card
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to let the AI use Sylvan Library if it's in a premade deck. The AI should just use it for card filtering, like Mirri's Guile. I have a test for casting, and a test for not paying life to keep more cards.
Disclaimer: this PR was mostly written by AI (Claude Code). I have reviewed the generated code. Let me know if any changes are needed!