Support engine tracking card mover vs. controller#6420
Support engine tracking card mover vs. controller#6420tool4ever wants to merge 9 commits intoCard-Forge:masterfrom
Conversation
tool4ever
added
Game Mechanics
Rules compliance
|
|
||
| // in some cases it's always affected that puts them in play (initially) | ||
| String defPutter; | ||
| if (cause == null || (!cause.hasParam("Putter") && (c.isToken() || |
There was a problem hiding this comment.
I don't know if I like it there
I probably would move the Putter logic into AbilityKey.addCardZoneTableParams
There was a problem hiding this comment.
hmn, the problem is the Putter can be different players during the same effect
and most effects currently don't need to modify moveParams between cards and reuse them instead
so I'd have to refactor those further, especially when they pass down to helpers in SpellAbilityEffect like with discard?
There was a problem hiding this comment.
imo it would be more clean if the stuff is done in the specific SpellAbilityEffect classes (or a helper function)
There was a problem hiding this comment.
@tool4ever can you move the Putter Logic into Effects instead?
There was a problem hiding this comment.
I tried but like I said above it got messy fast ;/
Not sure yet if I can find a cleaner approach
There was a problem hiding this comment.
i still think it would be cleaner in SpellAbilityEffect like classes
|
This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed |
# Conflicts: # forge-game/src/main/java/forge/game/replacement/ReplaceMoved.java # forge-gui/res/cardsfolder/a/assassins_trophy.txt # forge-gui/res/cardsfolder/a/avatar_of_growth.txt # forge-gui/res/cardsfolder/c/chaos_warp.txt # forge-gui/res/cardsfolder/c/cleansing_wildfire.txt # forge-gui/res/cardsfolder/c/crypt_champion.txt # forge-gui/res/cardsfolder/d/demolition_field.txt # forge-gui/res/cardsfolder/d/dire_strain_rampage.txt # forge-gui/res/cardsfolder/e/endless_whispers.txt # forge-gui/res/cardsfolder/e/exhume.txt # forge-gui/res/cardsfolder/f/fall_of_the_thran.txt # forge-gui/res/cardsfolder/f/field_of_ruin.txt # forge-gui/res/cardsfolder/g/geomancers_gambit.txt # forge-gui/res/cardsfolder/g/ghost_quarter.txt # forge-gui/res/cardsfolder/m/magister_of_worth.txt # forge-gui/res/cardsfolder/o/oath_of_lieges.txt # forge-gui/res/cardsfolder/o/old_growth_dryads.txt # forge-gui/res/cardsfolder/o/orochi_soul_reaver.txt # forge-gui/res/cardsfolder/p/path_to_exile.txt # forge-gui/res/cardsfolder/p/polymorph.txt # forge-gui/res/cardsfolder/p/proteus_staff.txt # forge-gui/res/cardsfolder/r/reweave.txt # forge-gui/res/cardsfolder/s/shape_anew.txt # forge-gui/res/cardsfolder/s/sundering_eruption_volcanic_fissure.txt # forge-gui/res/cardsfolder/t/tempt_with_discovery.txt # forge-gui/res/cardsfolder/t/transmogrify.txt # forge-gui/res/cardsfolder/v/volatile_fault.txt # forge-gui/res/cardsfolder/w/white_orchid_phantom.txt # forge-gui/res/cardsfolder/w/winds_of_abandon.txt
2 participants
Adds support that will be needed for #5137