Skip to content

AbilityManaPart: use Multiset for produced#10811

Merged
Hanmac merged 1 commit into
masterfrom
manaProducedOverMap
May 31, 2026
Merged

AbilityManaPart: use Multiset for produced#10811
Hanmac merged 1 commit into
masterfrom
manaProducedOverMap

Conversation

@Hanmac
Copy link
Copy Markdown
Contributor

@Hanmac Hanmac commented May 30, 2026

Part of #10750

This should help with producing big amount of Mana per ManaAbility,
it only creates one Mana Record instance per color type.

the multiset is still expanded when adding them to the ManaPool (for now)

I wanted to do the ManaPool too, but it got too complicated, so i do something smaller

Copy link
Copy Markdown
Contributor

@tool4ever tool4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as I can tell nothing seems to care about duplicate objects there

@Hanmac Hanmac marked this pull request as ready for review May 31, 2026 10:22
@Hanmac
Copy link
Copy Markdown
Contributor Author

Hanmac commented May 31, 2026

Technically, the Mana records are still duplicated,
just from [M, M] to {M=>2}

@Hanmac Hanmac merged commit fbfaa3d into master May 31, 2026
8 checks passed
@Hanmac Hanmac deleted the manaProducedOverMap branch May 31, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants