UNK: 15 cards, 4 tokens#10808
Conversation
| Assassin:Assassins | ||
| Assembly-Worker:Assembly-Workers | ||
| Astartes:Astartes | ||
| Athlete:Athletes |
There was a problem hiding this comment.
please use respective edition file for defining all these non-legal types instead
There was a problem hiding this comment.
I take it that's another cleanup.
I did manage to find an implementation of the syntax on a PR on a fork that referenced the relevant PR on Card-Forge.
However, since Athlete shows up on UNK and MB2, and the fork PR has the same creature type listed on two separate edition files, I do wonder how the redundancy, if any, works here. I'm leaning toward the redundancy not being strictly necessary but probably good to have for bookkeeping purposes, but best to confirm if that's indeed the case.
( @Eradev )
There was a problem hiding this comment.
There's no problem. Forge will safely ignore it if it already exists.
Some seemingly easy enough cards going from the most recent release back in time. Waiting on the merger of the following PR, #10740 , since it deals with a crash involving Bin Chicken's amass effect and it also updates the Un-card list. Also waiting on the merger of #10809 regarding the proper listing of non-legal subtypes per discussion below.
{2}{C}{C}{C}{2}cost to{4}{C}{C}{C}with no issue. Maybe it's better to skip that calculation altogether? Tested to satisfaction.TypeLists.txt. Tested to satisfaction.GenericChoicebetween the granted ETBs. Added Artist toTypeLists.txt. Tested to satisfaction.TypeLists.txt. Tested to satisfaction.