Try to get find cards in same set first#10397
Open
clairchiara wants to merge 2 commits intoCard-Forge:masterfrom
Open
Try to get find cards in same set first#10397clairchiara wants to merge 2 commits intoCard-Forge:masterfrom
clairchiara wants to merge 2 commits intoCard-Forge:masterfrom
Conversation
Contributor
|
I'd think if the card exists in the set but we've requested an invalid art index or collector number, that's a sign the problem is primarily with the request. In this case, it seems like that deck should be using art index 2. Note how they both have text in the bottom left indicating which deck they're meant for: Art index 1 - CN315 Falling back to the same set upon a failed request does make a kind of sense, but I think it'd make it harder to catch other mistakes like these. |
0b0aa94 to
7232f2a
Compare
Contributor
Author
|
@Jetz72 |
7232f2a to
1b1128f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If card is not found with artIndex and/or collectorNumber, try again to find it in the same set without them. Only then fallback to full database if still not found.
Example: the 40K commander precon "Ruinous Powers" contains
Mountain|40K|3. Although the 40K set has Mountains, it does not have one at artIndex 3. Currently this causes another Mountain to be loaded according to user art preferences, either from LEA or the latest set (eg TMT). A more logical behavior would be to load another Mountain from 40K instead, as these are available.