Adventure: Fixes and improvements for Save/Load scene and keyboard selection#10303
Open
EfourC wants to merge 3 commits intoCard-Forge:masterfrom
Open
Adventure: Fixes and improvements for Save/Load scene and keyboard selection#10303EfourC wants to merge 3 commits intoCard-Forge:masterfrom
EfourC wants to merge 3 commits intoCard-Forge:masterfrom
Conversation
- Fix memory leaks. - Improve Auto/Quick save slot name text handling. - Fix changing selection of save slots with keyboard. - Fix incorrect vertical offset when scrolling saves with keyboard. - Added usable toString()'s' for some UI controls. - Fixed re-selecting previously selected save slot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes various things, mainly in SaveLoadScene, but a few other places as well:
Edit: Also fixes the annoying bug where the save list scrolls to the bottom automatically when entering the Save/Load menu.
Any critique or other feedback welcome!