Repository navigation
test(gpui): pin the clock in the same-second diagnostics report test - #2715
Open
richiemcilroy wants to merge 1 commit into
Open
richiemcilroy wants to merge 1 commit into
richiemcilroy wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diagnostics::tests::reports_in_the_same_second_do_not_collideread the wall clock once per report, so whenever a second boundary fell between its two writes the stamps differed and the test failed. It has been failing other PRs' Intel macOS desktop job intermittently (e.g. #2664 and #2673:left: Some(1792431796) right: Some(1792431797)).write_report_intonow takes the time from a smallwrite_report_at(dir, report, stamp), and the test passes the same second to both writes. Production behaviour is unchanged:write_report_intostill stamps withSystemTime::now().cargo test --bin cap-gpui -- diagnostics: 14 passed.

Confidence Score: 5/5
This PR appears safe to merge.Summary
Makes
reports_in_the_same_second_do_not_collideindependent of the wall clock.Reviews (1) · Last reviewed commit: "test(gpui): pin the clock in the same-se..." · Reviewed by Greptile