Repository navigation
perf(desktop-gpui): keep long clip lists responsive - #2705
Merged
richiemcilroy merged 3 commits intoOct 19, 2026
Merged
Conversation
Contributor
|
@AksharP5 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long timelines make the Clips sidebar expensive to redraw because it builds every card, including hundreds outside the viewport. This uses GPUI's existing uniform list to render visible cards and keeps drag targets tied to their timeline indices.
Card rendering stays the same. Scroll limits and the final gap match the existing list. During inline rename, the list keeps all rows mounted so Enter and Escape still work after the input scrolls out of view.
Closes #2704.
Performance
Isolated native GPUI sidebar CPU measurements against current main:
Median scrolling work at the top of a 390 × 600 viewport. Seven alternating paired runs, 80 scroll events each after warmup, optimized build on an i5-14400F. The probe uses the actual card/list code, bundled assets/fonts, and pinned GPUI with Cap's patches. Starting midway through the list gives the same improvement. This measures component CPU work, excluding media I/O and GPU presentation; it is not a full-app FPS claim.
Validation
cargo check, formatting and all 24editor_clips::testspass.Checked all 276 open PRs and 211 other open issues, including overlapping file changes and discussions. Found no existing sidebar virtualization work.


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
The Clips sidebar now uses
uniform_listto build visible cards instead of the entire list.No actionable issues were found. This review checked source code; it did not run the app or tests.
Reviews (1) · Last reviewed commit: "perf(desktop-gpui): keep long clip lists..." · Reviewed by Greptile