Skip to content

fix(rendering): drive keyboard overlay from recording_time so it follows cuts and encoder start offset #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aacarcrash wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(rendering): drive keyboard overlay from recording_time so it follows cuts and encoder start offset #2118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions crates/rendering/src/layers/keyboard.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ impl KeyboardLayer {
pub fn prepare(
&mut self,
uniforms: &ProjectUniforms,
_segment_frames: &DecodedSegmentFrames,
segment_frames: &DecodedSegmentFrames,
output_size: XY<u32>,
constants: &RenderVideoConstants,
caption_layout: Option<CaptionOverlayLayout>,
Expand All @@ -304,7 +304,12 @@ impl KeyboardLayer {
return;
}

let current_time = uniforms.frame_number as f64 / uniforms.frame_rate as f64;
// Keyboard segments are authored on the recording clock. Use the same
// clock the cursor layer uses: recording_time travels with the decoded
// frame through the timeline mapping, so the overlay follows cuts and
// trims, and includes the recording→first-video-frame start offset
// that raw output time (frame_number / frame_rate) lacks.
let current_time = segment_frames.recording_time as f64;
let settings = &keyboard_data.settings;

let active_segment = find_active_keyboard_segment(
Expand Down