feat: make keymaps configurable via setup()#44
Merged
Conversation
The plugin previously hardcoded `]c`/`[c` (buffer-local in inline diff buffers) and `<leader>dq` (global), which conflicted with users' own mappings. Add a `keys` table to setup() with the existing values as defaults so behavior is unchanged. Each entry can be set to a different lhs or to `false` to skip the binding; `keys = false` disables all defaults. Also expose `<Plug>(CodePreviewCloseAll)` so users can bind the close action even when defaults are disabled. Closes #43 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keystable tosetup()so the previously hardcoded mappings (]c,[c,<leader>dq) can be customized or disabled<Plug>(CodePreviewCloseAll)for users who prefer to bind the close action themselvesCloses #43
Usage
Set any entry to
falseto skip that binding, orkeys = falseto skip them all and use<Plug>(CodePreviewCloseAll)directly.Test plan
]c/[c/<leader>dq) work unchanged across Claude Code, OpenCode, and GitHub Copilot CLI backends<leader>cn/<leader>cp/<leader>cq) bind correctly and the original defaults no longer triggerkeys = falsedisables all defaults;<Plug>(CodePreviewCloseAll)still bindable manuallyfalse(e.g.close_all = false) skips just that binding