Skip to content

Conversation

@marcoserenelli
Copy link
Contributor

@marcoserenelli marcoserenelli commented Nov 7, 2025

While reading the prompts, i found a small typo in the SQL correction prompt.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed a typo in the SQL correction system prompt to improve instruction clarity.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 7, 2025

Walkthrough

Fixed a typographical error in the SQL correction system prompt, changing "firgure out" to "figure out". This is a text-only correction with no impact on control flow, logic, or error handling.

Changes

Cohort / File(s) Summary
Typo correction
wren-ai-service/src/pipelines/generation/sql_correction.py
Fixed spelling error in system prompt: corrected "firgure out" to "figure out"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

  • Straightforward typo fix in prompt text requiring minimal verification

Suggested labels

wren-ai-service

Suggested reviewers

  • paopa
  • yichieh-lu

Poem

🐰 A typo in the prompt, so small,
"Firgure" became "figure"—no more squall!
The rabbit hops with glee,
Where clarity shall be,
One letter corrected, and all is well! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: fixing a typo ('firgure out' to 'figure out') in the SQL correction instructions prompt.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d07162 and 6189aa4.

📒 Files selected for processing (1)
  • wren-ai-service/src/pipelines/generation/sql_correction.py (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: andreashimin
Repo: Canner/WrenAI PR: 1414
File: wren-ui/src/apollo/server/utils/error.ts:0-0
Timestamp: 2025-03-18T10:28:10.593Z
Learning: The typo in error code enum names ("IDENTIED_AS_GENERAL" and "IDENTIED_AS_MISLEADING_QUERY" instead of "IDENTIFIED_AS_GENERAL" and "IDENTIFIED_AS_MISLEADING_QUERY") in wren-ui/src/apollo/server/utils/error.ts was recognized but intentionally not fixed as it was considered out of scope for PR #1414.
Learnt from: andreashimin
Repo: Canner/WrenAI PR: 1414
File: wren-ui/src/apollo/server/utils/error.ts:0-0
Timestamp: 2025-03-18T10:28:26.608Z
Learning: The enum names `IDENTIED_AS_GENERAL` and `IDENTIED_AS_MISLEADING_QUERY` in GeneralErrorCodes enum in wren-ui/src/apollo/server/utils/error.ts have typos (missing "FI" in "IDENTIFIED") but fixing them is not in scope for the current PR.
📚 Learning: 2025-03-18T10:28:26.608Z
Learnt from: andreashimin
Repo: Canner/WrenAI PR: 1414
File: wren-ui/src/apollo/server/utils/error.ts:0-0
Timestamp: 2025-03-18T10:28:26.608Z
Learning: The enum names `IDENTIED_AS_GENERAL` and `IDENTIED_AS_MISLEADING_QUERY` in GeneralErrorCodes enum in wren-ui/src/apollo/server/utils/error.ts have typos (missing "FI" in "IDENTIFIED") but fixing them is not in scope for the current PR.

Applied to files:

  • wren-ai-service/src/pipelines/generation/sql_correction.py
📚 Learning: 2025-03-18T10:28:10.593Z
Learnt from: andreashimin
Repo: Canner/WrenAI PR: 1414
File: wren-ui/src/apollo/server/utils/error.ts:0-0
Timestamp: 2025-03-18T10:28:10.593Z
Learning: The typo in error code enum names ("IDENTIED_AS_GENERAL" and "IDENTIED_AS_MISLEADING_QUERY" instead of "IDENTIFIED_AS_GENERAL" and "IDENTIFIED_AS_MISLEADING_QUERY") in wren-ui/src/apollo/server/utils/error.ts was recognized but intentionally not fixed as it was considered out of scope for PR #1414.

Applied to files:

  • wren-ai-service/src/pipelines/generation/sql_correction.py
🔇 Additional comments (1)
wren-ai-service/src/pipelines/generation/sql_correction.py (1)

33-33: LGTM!

The typo correction from "firgure out" to "figure out" in the SQL correction instruction improves prompt clarity. This fix is important as precise language in system prompts enhances LLM instruction adherence.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@marcoserenelli marcoserenelli marked this pull request as ready for review November 7, 2025 11:30
@cyyeh cyyeh self-requested a review November 10, 2025 14:27
Copy link
Member

@cyyeh cyyeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@cyyeh cyyeh merged commit b69f411 into Canner:main Nov 10, 2025
1 check passed
@marcoserenelli marcoserenelli deleted the patch-1 branch November 10, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants