fix: Breaking apart parent clip makes child clips undeletable#105
Open
StickmanRed wants to merge 1 commit intodevelopmentfrom
Open
fix: Breaking apart parent clip makes child clips undeletable#105StickmanRed wants to merge 1 commit intodevelopmentfrom
StickmanRed wants to merge 1 commit intodevelopmentfrom
Conversation
Fixes a bug where breaking apart a parent clip causes child clips to be undeletable.
Collaborator
|
Ooh I ran into this during the gamejam haha. Thanks for finding a fix Do you still have the code you used to verify this fix? I'd like to add it to the engine test suite |
Collaborator
Author
|
Not really, I just used the inspector "Break Apart" action and manually deleted the child clips... this code could be used to verify it though project.activeFrame.clips[0].breakApart();
let clip1 = project.activeFrame.clips[0];
clip1.remove();
// clip1.parent should equal nullalso, about the testing, would it be correct to add the bugfix test code after this line in test.Wick.Clip.js? |
Collaborator
|
Yup, I'd add the test there with a comment above it like
I'm not sure if running the tests still works on node14, but they are working on the node 24 branch with new instructions: d4797dd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes clip bug
The bug was caused by
_willBeRemovedbeing set totruebyclip.remove()inWick.Frame.addClip. Bugfix tested through console on Candlestick.Requires engine build to test