Skip to content

fix: include explicit speculative batch initialization in native pin - #5137

Merged
joelteply merged 4 commits into
canaryfrom
cbaf84de/pin-native-tagged-union-tool-grammar-cor
Oct 17, 2026
Merged

joelteply merged 4 commits into
canaryfrom
cbaf84de/pin-native-tagged-union-tool-grammar-cor

Conversation

@joelteply

@joelteply joelteply commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Pin the native grammar correction that preserves tagged edit arguments behind a transparent singleton allOf wrapper. The previous converter generated an empty-object-only rule for the captured EditMode union, rejecting valid search_replace arguments.

The native change is reviewed in CambrianTech/llama.cpp#66. It also explicitly initializes two existing speculative batch label_weight pointers, fixing the GCC missing-field-initializers error found by native CI without changing their zero initialization behavior.

Measured validation: the same active Release fixture fails with the old converter and passes with the fix; the Qwen XML roundtrip and existing JSON-schema suite pass. Fresh core checks and the supported GPU publisher must validate this exact pin before adoption. Recovery owns deployment identity/binding checks and observation of an actual valid edit; source tests alone do not establish coding recovery. No serving settings or model/adapters are changed here.
Further fresh CI exposed preexisting test-walk-exact build defects: unsigned window bound compared to signed loop index, and private symbols linked from a Windows DLL. The loop now uses uint32_t; the unchanged target is registered beside existing internal tests under NOT WIN32 OR NOT BUILD_SHARED_LIBS, retaining Linux and Windows static coverage. Windows static test-walk-exact compiles and links; no assertion or model scenario was removed.

@joelteply
joelteply marked this pull request as draft October 17, 2026 18:45
@joelteply
joelteply marked this pull request as ready for review October 17, 2026 18:47
@joelteply
joelteply merged commit 2a9b7f9 into canary Oct 17, 2026
9 checks passed
@joelteply
joelteply deleted the cbaf84de/pin-native-tagged-union-tool-grammar-cor branch October 17, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant