Repository navigation
fix: include explicit speculative batch initialization in native pin - #5137
Merged
joelteply merged 4 commits intoOct 17, 2026
Merged
Conversation
Assisted-by: Codex
…-tagged-union-tool-grammar-cor
Assisted-by: Codex
joelteply
marked this pull request as draft
October 17, 2026 18:45
joelteply
marked this pull request as ready for review
October 17, 2026 18:47
Assisted-by: Codex
joelteply
deleted the
cbaf84de/pin-native-tagged-union-tool-grammar-cor
branch
October 17, 2026 19:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin the native grammar correction that preserves tagged edit arguments behind a transparent singleton allOf wrapper. The previous converter generated an empty-object-only rule for the captured EditMode union, rejecting valid search_replace arguments.
The native change is reviewed in CambrianTech/llama.cpp#66. It also explicitly initializes two existing speculative batch label_weight pointers, fixing the GCC missing-field-initializers error found by native CI without changing their zero initialization behavior.
Measured validation: the same active Release fixture fails with the old converter and passes with the fix; the Qwen XML roundtrip and existing JSON-schema suite pass. Fresh core checks and the supported GPU publisher must validate this exact pin before adoption. Recovery owns deployment identity/binding checks and observation of an actual valid edit; source tests alone do not establish coding recovery. No serving settings or model/adapters are changed here.
Further fresh CI exposed preexisting test-walk-exact build defects: unsigned window bound compared to signed loop index, and private symbols linked from a Windows DLL. The loop now uses uint32_t; the unchanged target is registered beside existing internal tests under NOT WIN32 OR NOT BUILD_SHARED_LIBS, retaining Linux and Windows static coverage. Windows static test-walk-exact compiles and links; no assertion or model scenario was removed.