Simplify & update firefly_client use in Euclid PHZ tutorial#307
Conversation
jaladh-singhal
added
enhancement
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
Look good, but I have some linking suggestion that you may consider for a follow-up PR that touches all the firefly notebooks.
| else: | ||
| print("Creating data directory.") | ||
| os.mkdir(download_path) | ||
| fc = FireflyClient.make_client('https://irsa.ipac.caltech.edu/irsaviewer') |
There was a problem hiding this comment.
I would move this code cell down, right after current line 404. (I like having the narrative first and the see the code that does what the narrative describes)
| ### Vizualize the FITS image with Firefly | ||
|
|
||
| First initialize the client, then set the path to the image, upload it to firefly, load it and align with WCS. | ||
| After initializing the client, we can directly use the FITS image file URL to upload it to Firefy. |
There was a problem hiding this comment.
Unrelated to this PR; but I think we should cross link from firefly using notebooks to a firefly intro notebook. E.g. reading these updates from the POV of an e.g. fornax users of what you mean by "upload", if and how much of data transfer happens between what computers.
So, while all of that narrative would be nice, I don't think that we should repeat it in every notebook, but at minimum we should point to some docs or another notebook that answers those potential questions.
There was a problem hiding this comment.
I agree - we have too long text in other irsa-tutorials about initializing or too little text (like in this one). I'll make a ticket to standardize firefly initializing across notebooks and cross-linking a dedicated firefly-initializing notebook we have here: https://caltech-ipac.github.io/firefly_client/usage/initializing-vanilla.html
Simplify & update firefly_client use in Euclid PHZ tutorial b01365f
2 participants
I made these fixes recently when demoing the notebook on Fornax to Euclid HQ folks. Removes use of deprecated methods, attributes.