Add openuniverse2024 toc#302
Conversation
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
I made some minor suggestion about naming files and filling out the metadata. Neither of them are blockers, but I think especially the filenaming would make sense to make as part of this PR.
Also, testing is failing for relevant reasons.; these are blockers but once the other comments are addressed (or postponed to follow-up) I'm more than happy to deal with all there of these, especially the first two.
- irsadev is not accessible outside of the VPN; these notebooks cannot be executed/tested in circleCI/GHA
- the previously existing OU notebooks were too resource intensive for circleCI, and thus were ignored in preview executing: the file renames should be propagated into the config files.
- Some of the references/links are not resolvable and looking at the logs they look to be genuinely problematic and not just server side issues.
There was a problem hiding this comment.
I would say we may rename this file, too. All the other tutorials have a bit more verbose names including the survey/telescope/etc in there.
(The use case I have in mind is that the user downloads the notebook. Then they may loose the context of the subdirectory and thus end up with a very generic quickstart.md file as opposed to e.g. openuniverse_quickstart.md
| @@ -0,0 +1,386 @@ | |||
| --- | |||
| jupytext: | |||
There was a problem hiding this comment.
authors metadata needs to be added here
| # Point the astroquery IRSA client to the simulated VO endpoints. | ||
| # Must be connected to the IPAC VPN or local network to access these endpoints. | ||
| # TODO: replace irsadev with irsa when the simulated SIA is deployed to production. | ||
| Irsa.sia_url = "https://irsadev.ipac.caltech.edu/simulated/SIA" |
There was a problem hiding this comment.
we need to skip testing any of the notebooks that require VPN access
There was a problem hiding this comment.
these renames should be also made in the ignore testing files.
I can push changes for this once the content is ready for merging
|
@bsipocz I think I have addressed all of your comments and the CI issues that I understood (links). I also changed the URLS to point to ops instead of irsa dev. I don't know which notebooks you want to ignore, so I have not touched that at all. Please let me know if there is something else I should do here. |
2 participants
Builds on #301 Moves all six OpenUniverse2024-related tutorials (three pre-existing and three new) into
tutorials/simulated-data/OpenUniverse2024/ and updates the TOC and landing page to reflect the new structure.
Changes: