Skip to content

Add Euclid HATS Magnitude tutorial #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
troyraen merged 4 commits into from
Dec 24, 2025
Merged

Add Euclid HATS Magnitude tutorial #211

troyraen merged 4 commits into from
Dec 24, 2025

Conversation

@troyraen
Copy link
Contributor

@troyraen troyraen commented Dec 22, 2025

Adds the Magnitudes tutorial for the Euclid Q1 Merged Objects HATS Catalog.

Adds 1 (out of 6) notebooks for #191.

@troyraen troyraen self-assigned this Dec 22, 2025
@troyraen troyraen added enhancement New notebook or feature content: euclid Content related issues/PRs for notebooks with Euclid relevance content: parquet Content related issues/PRs for notebooks with parquet/HATS relevance content: cloud Content related issues/PRs for notebooks with cloud hosted data relevance labels Dec 22, 2025
@troyraen troyraen force-pushed the raen/issues/191/add-euclid-hats-tutorials-II branch 2 times, most recently from 0ccb952 to fff0c11 Compare December 23, 2025 00:54
@troyraen
Copy link
Contributor Author

troyraen commented Dec 23, 2025 •
edited
Loading

The short_title of the Introduction tutorial currently says "Merged Objects HATS Catalog". I'm changing that to just say "Introduction", but I'll wait for other feedback/changes before pushing another commit that restarts the testing and rendering. Fixed

@troyraen troyraen force-pushed the raen/issues/191/add-euclid-hats-tutorials-II branch from fff0c11 to 6631ad1 Compare December 23, 2025 12:45
@troyraen troyraen force-pushed the raen/issues/191/add-euclid-hats-tutorials-II branch from 6631ad1 to 3736f2b Compare December 23, 2025 13:13
bsipocz
bsipocz approved these changes Dec 23, 2025
View reviewed changes
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can go in.

jaladh-singhal
jaladh-singhal approved these changes Dec 23, 2025
View reviewed changes
Copy link
Member

@jaladh-singhal jaladh-singhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@troyraen this is good to merge once you address my minor narrative related comments below.

One more thing (which is probably just personal preference), both the plots can use a top-level title. There's a lot going on this multi-panel figures, I often find it easier to remember the big picture when a plot title is present when taking a hard look at different panels.

bsipocz
bsipocz reviewed Dec 24, 2025
View reviewed changes
tutorials/parquet-catalog-demos/euclid-q1-hats/4-euclid-q1-hats-magnitudes.md
Comment on lines +226 to +227
jupyter:
source_hidden: true
Copy link
Member

@bsipocz bsipocz Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a FYI for the future, not something to address in this PR: sadly this is not the correct syntax, we get build warnings; but I already have an issue for cleaning things up so let's go ahead with it as is.

Copy link
Contributor Author

@troyraen troyraen Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall something like that but I'm having trouble finding the issue.

Copy link
Member

@bsipocz bsipocz Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/IPAC-SW/ipac-sp-notebooks/issues/159 -- I usually open subissues there for things that are impacting all the JB2 repos we have

Copy link
Contributor Author

@troyraen troyraen Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was searching the project board for various labels and words like "hide" and "hidden" but couldn't find it.

@troyraen troyraen merged commit 02a9ff9 into Caltech-IPAC:main Dec 24, 2025
8 checks passed
@troyraen troyraen deleted the raen/issues/191/add-euclid-hats-tutorials-II branch December 24, 2025 01:26
github-actions bot pushed a commit that referenced this pull request Dec 24, 2025
@troyraen
Merge pull request #211 from troyraen/raen/issues/191/add-euclid-hats…
6dc2f0b 
…-tutorials-II

Add Euclid HATS Magnitude tutorial 02a9ff9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsipocz bsipocz bsipocz approved these changes

@jaladh-singhal jaladh-singhal jaladh-singhal approved these changes

Assignees

@troyraen troyraen

Labels

content: cloud Content related issues/PRs for notebooks with cloud hosted data relevance content: euclid Content related issues/PRs for notebooks with Euclid relevance content: parquet Content related issues/PRs for notebooks with parquet/HATS relevance enhancement New notebook or feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@troyraen @bsipocz @jaladh-singhal