Repository navigation
fix(agents): go-reviewer declares the Skill tool and loads the go-coding skills - #9
Merged
Merged
Conversation
…ing skills The agent was granted Read, Grep, Glob and Bash only, while its body told it to reference the go-errors, go-testing and other skills, and orchestrators were told to name those skills in its brief. Without the Skill tool it could do neither, and it said so in its reports. It now declares Skill, as php-coding's php-reviewer does, and its first review step loads go-coding:go-coding and the focused skill for each area the change touches. If the Skill tool is unavailable it says so and works from its dimensions. README, AGENTS.md, the go-coding router and docs/testing.md say it loads the skills itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go-reviewernow declares theSkilltool and loads the go-coding skills before it reviews.Until now its
tools:list held onlyRead,Grep,GlobandBash. Its body told it to reference thego-errors,go-testingand other skills, and orchestrator briefs name those skills, but without theSkilltool it could not load any of them. In a Cadasto/cdr review it said so and cited rules from its own prompt instead.agents/go-reviewer.md:tools:gainsSkill, asphp-coding:php-revieweralready has.go-coding:go-coding, then the focused skill for each area the change touches.Skilltool is unavailable, the agent says so and works from its review dimensions.README.md(the Components row and Using with subagent orchestrators),AGENTS.md,skills/go-coding/SKILL.mdanddocs/testing.mdsay the agent loads the skills itself.CHANGELOG.md: two lines under[Unreleased]→ Fixed. No version bump: that happens at release, together with the marketplace repin.Checklist
./scripts/validate.shpasses.python3 scripts/validate.py --selftestpasses, with 9 of 9 checks catching their own failure case.claude plugin validate .passes. Its three warnings about the unquoted${CLAUDE_PLUGIN_ROOT}inhooks/hooks.jsonwere already onmain.claude -p --plugin-dir <this checkout>in a Go repository; go-coding loaded from the working copy only.go-coding:go-reviewerreview of one function, with nothing in the brief about skills.Skilltool forgo-coding:go-coding,go-coding:go-idiomsandgo-coding:go-errors, then returned severity-ranked findings that named them.php-reviewerships the sameSkillgrant to both hosts.[Unreleased]notes are in.🤖 Generated with Claude Code