Skip to content

fix(agents): go-reviewer declares the Skill tool and loads the go-coding skills - #9

Merged
sebastian-iancu merged 1 commit into
mainfrom
fix/go-reviewer-skill-tool
Oct 5, 2026
Merged

sebastian-iancu merged 1 commit into
mainfrom
fix/go-reviewer-skill-tool

Conversation

@sebastian-iancu

Copy link
Copy Markdown
Contributor

Summary

go-reviewer now declares the Skill tool and loads the go-coding skills before it reviews.

Until now its tools: list held only Read, Grep, Glob and Bash. Its body told it to reference the go-errors, go-testing and other skills, and orchestrator briefs name those skills, but without the Skill tool it could not load any of them. In a Cadasto/cdr review it said so and cited rules from its own prompt instead.

  • agents/go-reviewer.md:
    • tools: gains Skill, as php-coding:php-reviewer already has.
    • A new first review step loads go-coding:go-coding, then the focused skill for each area the change touches.
    • Each finding cites the skill its rule comes from.
    • If the Skill tool is unavailable, the agent says so and works from its review dimensions.
  • Docs: README.md (the Components row and Using with subagent orchestrators), AGENTS.md, skills/go-coding/SKILL.md and docs/testing.md say the agent loads the skills itself.
  • CHANGELOG.md: two lines under [Unreleased] → Fixed. No version bump: that happens at release, together with the marketplace repin.

Checklist

  • ./scripts/validate.sh passes. python3 scripts/validate.py --selftest passes, with 9 of 9 checks catching their own failure case.
  • claude plugin validate . passes. Its three warnings about the unquoted ${CLAUDE_PLUGIN_ROOT} in hooks/hooks.json were already on main.
  • Agent triggering tested locally (Claude Code):
    • Ran claude -p --plugin-dir <this checkout> in a Go repository; go-coding loaded from the working copy only.
    • Asked for a go-coding:go-reviewer review of one function, with nothing in the brief about skills.
    • The agent called the Skill tool for go-coding:go-coding, go-coding:go-idioms and go-coding:go-errors, then returned severity-ranked findings that named them.
  • Cursor install tested locally: not run. No manifest, rule or hook changed. The agent file is shared, and php-reviewer ships the same Skill grant to both hosts.
  • Both manifests in sync: no metadata changed.
  • Cursor rule files and path map: no change needed.
  • Version bumped: left for the release; the [Unreleased] notes are in.
  • Docs synced: no component was added or renamed. The docs that describe the agent are updated.

🤖 Generated with Claude Code

…ing skills

The agent was granted Read, Grep, Glob and Bash only, while its body told it
to reference the go-errors, go-testing and other skills, and orchestrators
were told to name those skills in its brief. Without the Skill tool it could
do neither, and it said so in its reports.

It now declares Skill, as php-coding's php-reviewer does, and its first review
step loads go-coding:go-coding and the focused skill for each area the change
touches. If the Skill tool is unavailable it says so and works from its
dimensions. README, AGENTS.md, the go-coding router and docs/testing.md say
it loads the skills itself.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sebastian-iancu
sebastian-iancu merged commit ac76967 into main Oct 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant