fix: plugin-definitions QA pass — skill nudge reaches the model, repeated guidance trimmed

[sebastian-iancu]

Summary

A QA pass over the plugin's skills, agent, Cursor rule and hooks, checked against the plugin-dev skill-development, agent-development and hook-development guidance and the current Claude Code hooks and skills docs.

Fixes

• The skill nudge never reached the model. Under Claude Code, hooks/skill-nudge.sh printed {"systemMessage": …}. The hooks reference defines systemMessage as a "warning message shown to the user"; the model-facing channel is hookSpecificOutput.additionalContext. The hook now uses that, so the nudge can do its job. Cursor still gets a plain line. Tests and the four docs that described the old channel are updated.
• Unquoted ${CLAUDE_PLUGIN_ROOT} in hooks/hooks.json: claude plugin validate warned that a plugin path containing a space would split the command. It is quoted now and the warnings are gone.
• go-testing promised a rule it did not have. Its description and the router's Route, then load table send "can-fail control" work to go-testing, but the body never covered it. The rule is added.
• $CLAUDE_FILE_PATH was described as set by Claude Code; no host sets it. It stays as a test override, and the comments and AGENTS.md now say so.
• Cursor rule: the layout row now names the same revive rules and gofmt doc-comment layout as the router.

Trims (no rule removed)

Guidance stated two or three times now appears once:

Component	Change	Size
go-idioms	Go 1.27 go fix changes stated once (in Newer in Go 1.27); strings.CutLast/bytes.CutLast get a table row, verified on Go 1.27.1	1,625 → 1,476 words
go-coding	gopls advice, a paragraph restating Route, then load, the orchestrator instruction; drops a reference to "the project research", which the consuming model can't see	978 → 914 words
go-lint-setup	migrate details and version-pinning advice	944 → 901 words
go-errors, go-testing	%v-instead-of-%w; -race; the cryptotest/t.Parallel warning	small
go-reviewer	description 1,232 → 984 chars (it loads in every session); body 10,682 → 9,994 chars	1,608 → 1,520 words

go-lint-setup now pre-approves Bash(golangci-lint *) instead of all of Bash. The skills docs note that allowed-tools grants are not gated by workspace trust.

Validator

scripts/validate.py now fails when the /go-lint-setup scaffold block and references/golangci.v2.yml enable a different default, linters or formatters. Both copies already said "keep in sync", but nothing enforced it. This extends the existing advice-equals-tooling check, so the documented count of three invariants still holds. A new --selftest case shows the check fires on drift and stays quiet on a clean tree.

For the reviewer

• The can-fail rule has no style-guide citation; it is the plugin's own practice, as it already was in the router's checklist. Label it as house practice if you prefer.
• go-reviewer's "Import and literal hygiene" dimension is caught entirely by revive and go vet, which conflicts with the agent's own "don't report what linters catch" rule. It was left in because CHANGELOG 0.6.0 shows it was added on purpose.

Checklist

• ./scripts/validate.sh passes. The Fixer-column check soft-skipped locally (Go 1.27 on PATH); the Fixer table is unchanged, and CI's 1.26 job runs it.
• claude plugin validate . passes, with no warnings now.
• Skill / command / agent triggering tested locally. Not done. Worth one claude --debug session that edits a *.go file, to confirm the nudge arrives as a system reminder.
• Cursor install tested locally. Not done. The rule and the Claude-side hook output changed; the Cursor hook output did not.
• Both manifests kept in sync (metadata unchanged)
• Cursor rule files and the .cursor-plugin/plugin.json path map kept in step (no components added or removed)
• CHANGELOG.md updated under [Unreleased]; version bump left for the release commit
• Docs synced: no components added or renamed. AGENTS.md, README.md, docs/install.md and docs/testing.md are updated for the hook change.

Also run: python3 scripts/validate.py --selftest (10/10), ./scripts/hooks-test.sh (28/28), python3 scripts/validate.py --check-links (64/64).

🤖 Generated with Claude Code