Skip to content

Start with OCP8 - #2076

Merged
adam-urbanczyk merged 26 commits into
masterfrom
adam-ocp8
Sep 4, 2026
Merged

Start with OCP8#2076
adam-urbanczyk merged 26 commits into
masterfrom
adam-ocp8

Conversation

@adam-urbanczyk

@adam-urbanczyk adam-urbanczyk commented Jul 31, 2026

Copy link
Copy Markdown
Member

OCCT8 / OCP8 support in CQ.

@adam-urbanczyk
adam-urbanczyk marked this pull request as draft July 31, 2026 09:28
@adam-urbanczyk adam-urbanczyk reopened this Aug 8, 2026
@adam-urbanczyk adam-urbanczyk reopened this Aug 9, 2026
@adam-urbanczyk

adam-urbanczyk commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

We are down to a single test failing that requires fixes on the OCP side. See CadQuery/OCP#219

@adam-urbanczyk

Copy link
Copy Markdown
Member Author

All green on the branch now.

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.67%. Comparing base (d6729f5) to head (65593f1).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2076      +/-   ##
==========================================
- Coverage   95.72%   95.67%   -0.05%     
==========================================
  Files          30       30              
  Lines        9533     9534       +1     
  Branches     1421     1421              
==========================================
- Hits         9125     9122       -3     
- Misses        253      255       +2     
- Partials      155      157       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adam-urbanczyk
adam-urbanczyk requested review from jmwright and lorenzncode and removed request for lorenzncode August 29, 2026 08:33
@adam-urbanczyk
adam-urbanczyk marked this pull request as draft August 29, 2026 16:26
@adam-urbanczyk

Copy link
Copy Markdown
Member Author

Converting back to draft, I'll still use this to check 8.0.0.1. No changes expected.

Comment thread cadquery/occ_impl/geom.py Outdated
Comment thread cadquery/occ_impl/geom.py Outdated
Comment thread cadquery/occ_impl/solver.py Outdated
Co-authored-by: AU <adam-urbanczyk@users.noreply.github.com>
@adam-urbanczyk
adam-urbanczyk marked this pull request as ready for review August 30, 2026 19:13
@adam-urbanczyk

Copy link
Copy Markdown
Member Author

@jmwright @lorenzncode ready for review again.

Comment thread cadquery/occ_impl/geom.py Outdated
adam-urbanczyk and others added 4 commits August 31, 2026 08:04
Raise on empty BB

Co-authored-by: Lorenz <hello@lorenz.space>
Ensure that empty BB raises

@lorenzncode lorenzncode left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adam-urbanczyk ! I did not find any issues. I tested with pixi manifest:

Details [workspace] channels = ["cadquery", "conda-forge"] name = "cq-2076" platforms = ["linux-64"]

[tasks]

[dependencies]
python = ">=3.11"
ocp = "==8.0.0.1"
ezdxf = ">=1.3.0"
multimethod = ">=1.11,<2.0"
docutils = ">=0.22.4,<0.23"
sphinx = "9.1.0.*"
pytest = ">=9.0.3,<10"
ruff = ">=0.15.13,<0.16"
starlette = ">=1.2.1,<2"
uvicorn-standard = ">=0.49.0,<0.50"
mypy = ">=2.1.0,<3"
casadi = ">=3.7.2,<4"
trame = ">=3.13.2,<4"
trame-vtk = ">=2.11.16,<3"
trame-components = ">=2.5.0,<3"
trame-vuetify = ">=3.2.5,<4"
numba = ">=0.67.0,<0.68"
nlopt = ">=2.11.0,<3"
runtype = ">=0.5.3,<0.6"
scipy = ">=1.18.0,<2"
pip = ">=26.2.1,<27"
ipython = ">=9.17.1,<10"

[pypi-dependencies]
cadquery = { path = "/home/lorenzn/devel/cq-2076", editable = true }
sphinx_rtd_theme = "==3.1.0"

Also tested with Python 3.12, 3.13, 3.14. I did some limited interactive testing including show, fig.

@adam-urbanczyk

Copy link
Copy Markdown
Member Author

Thanks, same here. Interactive and vis seems to be indeed working without any changes.

@jmwright

jmwright commented Sep 2, 2026

Copy link
Copy Markdown
Member

@adam-urbanczyk Thanks for doing this. Two notes:

  1. The cadquery-ocp pin in setup.py has not been updated to include 8.0.x.
  2. [Face/Edge].makeSplineApprox seems like it can now throw Standard_ConstructionError: WorkDegree too small for given ConstraintOrder, which looks like it will short-circuit the IsDone logic in some cases but not all. Does it matter that in some cases the code could throw a ValueError, and in others a Standard_ConstructionError? Could that account for the small drop in coverage?

@adam-urbanczyk

adam-urbanczyk commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

I fixed (1), thanks!

Regarding (2). I cannot find a condition that would result in IsDone()==False. I'm only getting exceptions. AFAICT (cf. https://github.com/Open-Cascade-SAS/OCCT/blob/3d097a0328e71b826377d4814ab05ec3c3d23871/src/ModelingAlgorithms/TKGeomAlgo/GeomAPI/GeomAPI_PointsToBSpline.cxx#L115) there is not path to get to false. For now I propose to leave as-is and revisit later with more field experience. Adding a ticket to track this (see #2087).

@jmwright jmwright left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adam-urbanczyk !

@adam-urbanczyk
adam-urbanczyk merged commit 278e75a into master Sep 4, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants