Skip to content

Nurbs extensions#2019

Draft
adam-urbanczyk wants to merge 18 commits intomasterfrom
nurbs-extensions
Draft

Nurbs extensions#2019
adam-urbanczyk wants to merge 18 commits intomasterfrom
nurbs-extensions

Conversation

@adam-urbanczyk
Copy link
Copy Markdown
Member

@adam-urbanczyk adam-urbanczyk commented Mar 20, 2026

Quite some improvements for the NURBS module.

  • direct visualization of Surface, Curve and their control points vis fig.show and show
  • isoline construction
  • isoline extraction matrix construction
  • fixed off by one evaluation error for periodic curves and surfaces
  • constrainedApproximate2D
  • tests

@adam-urbanczyk adam-urbanczyk marked this pull request as draft March 20, 2026 22:46
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 99.29078% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.69%. Comparing base (8290128) to head (778c8f2).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cadquery/occ_impl/nurbs.py 99.17% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2019      +/-   ##
==========================================
+ Coverage   95.00%   95.69%   +0.69%     
==========================================
  Files          30       30              
  Lines        8742     9087     +345     
  Branches     1298     1357      +59     
==========================================
+ Hits         8305     8696     +391     
+ Misses        289      239      -50     
- Partials      148      152       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adam-urbanczyk adam-urbanczyk marked this pull request as ready for review April 3, 2026 17:12
@adam-urbanczyk adam-urbanczyk requested review from jmwright and lorenzncode and removed request for lorenzncode April 3, 2026 17:29
@jmwright
Copy link
Copy Markdown
Member

jmwright commented Apr 3, 2026

@adam-urbanczyk I've restarted the MacOS CI job 4 times and it keeps failing. Restarting once or twice is normally enough.

@adam-urbanczyk
Copy link
Copy Markdown
Member Author

Yup. For some reason mypy fails to start. I'll investigate.

@adam-urbanczyk adam-urbanczyk marked this pull request as draft April 4, 2026 14:21
@adam-urbanczyk
Copy link
Copy Markdown
Member Author

I'll still investgate what's breaking with the newest mypy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants