Skip to content

stop eachpoint(..., useLocalCoordinates=False) from manipulating the object's location#1100

Open
greyltc wants to merge 2 commits intoCadQuery:masterfrom
greyltc:eachpoint-fix2
Open

stop eachpoint(..., useLocalCoordinates=False) from manipulating the object's location#1100
greyltc wants to merge 2 commits intoCadQuery:masterfrom
greyltc:eachpoint-fix2

Conversation

@greyltc
Copy link
Copy Markdown
Contributor

@greyltc greyltc commented Jun 8, 2022

fixes #1099

@greyltc
Copy link
Copy Markdown
Contributor Author

greyltc commented Jun 8, 2022

Even better would be a change that turns eachpoint() into a thin wrapper around each() with only the logic for converting the objects to points.

@jmwright
Copy link
Copy Markdown
Member

jmwright commented Jan 7, 2023

@greyltc The eachpoint test seems to be failing on this PR.

@greyltc
Copy link
Copy Markdown
Contributor Author

greyltc commented Jan 7, 2023

Sorry, maybe I'm looking in the wrong place, but I can't see the details of the failure. All I can see is

Check failure on line 1059 in Build log

@azure-pipelinesazure-pipelines
/ CadQuery.cadquery (Linux_3_10)
Build log #L1059
Bash exited with code '1'.

I clicked on "View more details on Azure Pipelines" there but that takes me to a page that says "build not found".

This PR makes a fundamental change to the way eachpoint works with useLocalCoordinates=False so I assume the test pass criteria needs to be rewritten to match that, but it would be nice to see the verbose check failure output to make sure.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 7, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.07%. Comparing base (a5fadeb) to head (87890b8).
⚠️ Report is 373 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1100      +/-   ##
==========================================
- Coverage   96.34%   94.07%   -2.28%     
==========================================
  Files          40       26      -14     
  Lines        9533     5421    -4112     
  Branches     1259      919     -340     
==========================================
- Hits         9185     5100    -4085     
+ Misses        205      190      -15     
+ Partials      143      131      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adam-urbanczyk adam-urbanczyk self-requested a review January 12, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eachpoint(..., useLocalCoordinates=False) manipulates the point's location when it shouldn't

3 participants